OLMIS-7304: Added sending orderable to one-network-integration-service

Activity

FEOLMIS-4413 26

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 2h 6m 3 Yes, you're right
    Reviewer - Complete 2h 4m 23 I think you can rename this to processBufferedData
    Total   4h 11m 26  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/admin-one-network-integration/admin-one-network-integration.controller.js Changed
    Open in IDE #permalink
    /src/admin-one-network-integration/admin-one-network-integration.controller.spec.js Changed
    /src/admin-one-network-integration/admin-one-network-integration.html Changed
    Open in IDE #permalink
    /src/admin-one-network-integration/admin-one-network-integration.module.js Changed
    Open in IDE #permalink
    /src/admin-one-network-integration/admin-one-network-integration.routes.js Changed
    Open in IDE #permalink
    /src/admin-one-network-integration/admin-one-network-integration.routes.spec.js Changed
    /src/admin-one-network-integration/messages_en.json Changed
    Open in IDE #permalink
    /src/one-network-integration/one-network-integration.module.js Added
    Open in IDE #permalink
    /src/one-network-integration/one-network-integration.service.js Added
    Open in IDE #permalink
    /src/one-network-integration/one-network-integration.service.spec.js Added
    Open in IDE #permalink
    /src/one-network-integration-scheduler/one-network-integration-scheduler.module.js Deleted
    Open in IDE #permalink
    /src/one-network-integration-scheduler/one-network-integration-scheduler.service.js Deleted
    Open in IDE #permalink
    /src/one-network-integration-scheduler/one-network-integration-scheduler.service.spec.js Deleted
    Open in IDE #permalink
    /src/main/.../events/OrderableCreateEvent.java Changed
    Open in IDE #permalink
    /src/main/.../events/OrderableUpdateEvent.java Changed
    Open in IDE #permalink
    /src/main/.../events/ProductsObserver.java Deleted
    Open in IDE #permalink
    /src/.../service/OrderableIntegrationDataException.java Added
    Open in IDE #permalink
    /src/.../service/OrderableIntegrationDataService.java Added
    Open in IDE #permalink
    /src/.../events/OrderableCreateEventTest.java Changed
    Open in IDE #permalink
    /src/.../events/OrderableUpdateEventTest.java Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed
    Open in IDE #permalink
    /build.gradle Changed
    Open in IDE #permalink
    /src/.../configuration/IntegrationConfiguration.java Added
    Open in IDE #permalink
    /src/.../configuration/SchedulerConfiguration.java Deleted
    Open in IDE #permalink
    /src/main/.../domain/Orderable.java Deleted 1
    Open in IDE #permalink
    /src/main/.../domain/OrderableForCsv.java Deleted
    Open in IDE #permalink
    /src/main/.../domain/OrderableWrapper.java Deleted
    Open in IDE #permalink
    /src/main/.../domain/SchedulerStatus.java Deleted
    Open in IDE #permalink
    /src/main/.../dto/IntegrationStatus.java Added
    Open in IDE #permalink
    /src/main/.../integration/dto/Orderable.java Added
    /src/main/.../dto/OrderableForCsv.java Added
    /src/main/.../dto/OrderableWrapper.java Added
    Open in IDE #permalink
    /src/main/.../dto/SchedulerStatus.java Deleted
    Open in IDE #permalink
    /src/.../exception/DataRetrievalException.java Added
    Open in IDE #permalink
    /src/main/.../scheduler/ScheduledTasks.java Added
    Open in IDE #permalink
    /src/main/java/.../service/csv/CsvService.java Added
    Open in IDE #permalink
    /src/.../referencedata/OrderableDataService.java Added
    /src/main/.../referencedata/OrderableDto.java Deleted
    Open in IDE #permalink
    /src/main/.../request/RequestHeaders.java Added
    Open in IDE #permalink
    /src/main/.../request/RequestHelper.java Added
    Open in IDE #permalink
    /src/main/.../request/RequestParameters.java Added
    Open in IDE #permalink
    /src/main/.../service/AuthService.java Added
    Open in IDE #permalink
    /src/main/.../service/BasicQueue.java Deleted 4
    Open in IDE #permalink
    /src/main/.../service/BufferService.java Added
    Open in IDE #permalink
    /src/main/.../service/CsvService.java Deleted
    Open in IDE #permalink
    /src/.../service/OrderableBufferService.java Added 2
    Open in IDE #permalink
    /src/main/.../service/OrderableCsvService.java Deleted
    Open in IDE #permalink
    /src/main/.../service/OrderableQueue.java Deleted 1
    Open in IDE #permalink
    /src/.../service/OrderableQueueService.java Deleted
    Open in IDE #permalink
    /src/main/.../service/ProcessingService.java Added 2
    /src/main/.../service/Scheduler.java Deleted
    Open in IDE #permalink
    /src/main/.../integration/sftp/SftpClient.java Changed
    Open in IDE #permalink
    /src/main/.../sftp/SftpService.java Changed 1
    Open in IDE #permalink
    /src/main/.../web/IntegrationController.java Added 2
    Open in IDE #permalink
    /src/main/.../web/OrderableController.java Added 6
    Open in IDE #permalink
    /src/main/.../web/SchedulerController.java Deleted 7
    Open in IDE #permalink
    /src/main/.../integration/Application.java Changed
    Open in IDE #permalink
    /src/main/.../schemas/integrationStatus.json Added
    Open in IDE #permalink
    /src/main/resources/schemas/orderable.json Added
    Open in IDE #permalink
    /src/main/.../schemas/schedulerStatus.json Deleted
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed
    /src/main/resources/application.properties Changed
    /src/test/.../domain/OrderableTest.java Deleted
    Open in IDE #permalink
    /src/test/.../dto/OrderableTest.java Added
    Open in IDE #permalink
    /src/test/.../service/csv/CsvServiceTest.java Added
    /src/.../referencedata/OrderableDataServiceTest.java Added
    /src/.../service/OrderableBufferServiceTest.java Added
    Open in IDE #permalink
    /src/.../service/OrderableQueueServiceTest.java Deleted
    Open in IDE #permalink
    /src/test/.../service/OrderableQueueTest.java Deleted
    Open in IDE #permalink
    /src/test/.../sftp/SftpServiceTest.java Added
    Open in IDE #permalink
    /src/test/.../util/MessageTest.java Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /README.md Changed
    Open in IDE #permalink
    /build.gradle Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time