TZUP-207 Users

Activity

FEOLMIS-4410 7

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 43m 3 Can you review again. I have solved also duplicate issue ...
    Reviewer - 0% reviewed 0m    
    Reviewer - Complete 11m 4 In the transform, you can probably replace verified null ...
    Total   55m 7  

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Chongsun Ahn

    Can you explain what detect username duplicate processor is?

    Can you explain what detect username duplicate processor is?

    Felix M Joseph

    There is a lot of username duplicates in v2 users table. It seems there is no...

    There is a lot of username duplicates in v2 users table. It seems there is no unique constraints. It was generating constants exceptions in v3 users table.

    Chongsun Ahn

    The supervisorid doesn't seem to point to a supervisory node, but rather to a...

    The supervisorid doesn't seem to point to a supervisory node, but rather to another user id.

    Chongsun Ahn

    Can you explain why you are checking payloadverified is empty and deleting if...

    Can you explain why you are checking payloadverified is empty and deleting if it is? Delete entries in Kafka are only if the payload is empty. In the initial populating, there should be no deletes.

    Felix M Joseph

    In v2 users table at verified column there is data which have null value inst...

    In v2 users table at verified column there is data which have null value instead of true or false. And v3 verified is mandatory. And most of them it seem was added and never used. May be if we can clean them first before running scripts.

    Chongsun Ahn

    In the transform, you can probably replace verified null to verified false.

    In the transform, you can probably replace verified null to verified false.

    Felix M Joseph

    Can you review again. I have solved also duplicate issue it was caused by cas...

    Can you review again. I have solved also duplicate issue it was caused by case sensitive.

    /config/.../templates/TransformUsersV2ToV3.xml Added
    Open in IDE #permalink
    /connect-reg/connectors/register-v2-source.json Changed
    /connect-reg/connectors/register-v3-sink.json Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time