TZUP-209 Added API for managing (create,update, delete and search) equipment...

Activity

FEOLMIS-4385 21

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1h 37m 9 Why will we need that information for the equipment model...
    Reviewer - Complete 31m 5 Okay
    Reviewer - Complete 31m 7 I'm not sure what you mean. This test class does not exte...
    Reviewer - 96% reviewed 18m    
    Total   2h 58m 21  
    #permalink

    Objectives

    Implemented API for managing (create,update, delete and search) equipment models. This is in relation to TZUP-209

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Chongsun Ahn

    I don't see any unit or integration tests here.

    I don't see any unit or integration tests here.

    Boniface Chacha

    I have pushed the integration and unit tests

    I have pushed the integration and unit tests

    Ian

    Add some information on the ticket

    Add some information on the ticket

      Ian marked as Resolved 29 Jul

    Boniface Chacha

    I have added more information on both TZUP-209 and TZUP-210

    I have added more information on both TZUP-209 and TZUP-210

    /src/.../repository/EquipmentModelRepositoryIntegrationTest.java Added 4
    Open in IDE #permalink
    /src/.../service/EquipmentModelServiceIntegrationTest.java Added
    Open in IDE #permalink
    /src/.../service/EquipmentModelServiceSearchIntegrationTest.java Deleted
    Open in IDE #permalink
    /src/.../web/BaseWebIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/CatalogItemControllerIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/DeviceControllerIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/DisciplineControllerIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/EquipmentCategoryControllerIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/EquipmentModelControllerIntegrationTest.java Added
    Open in IDE #permalink
    /src/.../web/EquipmentTestTypeControllerIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/EquipmentTypeControllerIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/InventoryItemControllerIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/OperationModeControllerIntegrationTest.java Changed
    Open in IDE #permalink
    /src/main/.../equipment/domain/BaseEntity.java Changed
    Open in IDE #permalink
    /src/main/.../domain/EquipmentModel.java Added
    /src/main/.../dto/EquipmentModelDto.java Added
    Open in IDE #permalink
    /src/.../i18n/EquipmentModelMessageKeys.java Added
    Open in IDE #permalink
    /src/.../i18n/EquipmentTypeMessageKeys.java Added
    Open in IDE #permalink
    /src/main/.../equipment/i18n/MessageKeys.java Changed
    Open in IDE #permalink
    /src/main/.../i18n/SystemMessageKeys.java Added
    Open in IDE #permalink
    /src/.../impl/CatalogItemRepositoryImpl.java Changed
    Open in IDE #permalink
    /src/.../impl/EquipmentModelRepositoryImpl.java Added
    Open in IDE #permalink
    /src/.../impl/InventoryItemRepositoryImpl.java Changed
    Open in IDE #permalink
    /src/.../custom/EquipmentModelRepositoryCustom.java Added
    Open in IDE #permalink
    /src/.../repository/EquipmentModelRepository.java Added 1
    Open in IDE #permalink
    /src/.../service/EquipmentModelService.java Added 4
    /src/.../service/InventoryItemService.java Changed
    Open in IDE #permalink
    /src/main/.../equipment/util/Pagination.java Deleted
    Open in IDE #permalink
    /src/main/.../util/PaginationUtil.java Added
    Open in IDE #permalink
    /src/main/.../equipment/util/UuidUtil.java Added
    Open in IDE #permalink
    /src/main/.../web/BaseController.java Changed
    Open in IDE #permalink
    /src/main/.../web/CatalogItemController.java Changed
    Open in IDE #permalink
    /src/main/.../web/DeviceController.java Changed
    Open in IDE #permalink
    /src/main/.../web/DisciplineController.java Changed
    Open in IDE #permalink
    /src/.../web/EquipmentModelController.java Added 2
    /src/.../web/EquipmentModelSearchParams.java Added
    Open in IDE #permalink
    /src/main/.../web/InventoryItemController.java Changed
    Open in IDE #permalink
    /src/main/.../web/OperationModeController.java Changed
    Open in IDE #permalink
    /src/main/.../equipment/web/RequestParams.java Added
    Open in IDE #permalink
    /src/.../equipment/AuditLogInitializer.java Changed
    Open in IDE #permalink
    /src/.../equipment/CustomWebMvcConfigurerAdapter.java Changed
    Open in IDE #permalink
    /src/.../migration/20210711143725944__create_equipment_model_table.sql Added 3
    Open in IDE #permalink
    /src/main/.../schemas/equipmentModel.json Added
    Open in IDE #permalink
    /src/main/.../schemas/equipmentModelPage.json Added
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed 3
    Open in IDE #permalink
    /src/test/.../dto/EquipmentModelDtoTest.java Added
    Open in IDE #permalink
    /src/.../service/EquipmentModelServiceTest.java Added
    /src/.../service/InventoryItemServiceTest.java Changed
    Open in IDE #permalink
    /src/.../util/EquipmentModelDataBuilder.java Added
    Open in IDE #permalink
    /src/.../web/EquipmentModelControllerTest.java Added

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time