TZUP-156 : Backend to store reason for R&R been rejected

Activity

FEOLMIS-4243 11

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 57m 4 Done
    Reviewer - Complete 18m 1 Is a CHANGELOG entry created for this code?
    Reviewer - Complete 21m 6 Instead of just checking it is not null, shouldn't we be ...
    Total   1h 36m 11  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Elias

    Is a CHANGELOG entry created for this code?

    Is a CHANGELOG entry created for this code?

    Ian

    Done

    Done

    /src/.../web/RequisitionControllerIntegrationTest.java Changed
    /src/main/.../requisition/StatusChange.java Changed
    Open in IDE #permalink
    /src/main/.../domain/Rejection.java Added
    Open in IDE #permalink
    /src/main/.../dto/RejectionDto.java Added 1
    /src/main/.../dto/StatusChangeDto.java Changed
    Open in IDE #permalink
    /src/main/.../i18n/MessageKeys.java Changed
    Open in IDE #permalink
    /src/.../repository/RejectionRepository.java Added
    Open in IDE #permalink
    /src/main/.../service/RequisitionService.java Changed 7
    /src/main/.../web/RequisitionController.java Changed 1
    Open in IDE #permalink
    /src/.../migration/20201117130741211__schema_for_requisition_rejection_table.sql Added
    Open in IDE #permalink
    /src/main/.../schemas/rejectionDto.json Added
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed
    Open in IDE #permalink
    /src/main/resources/messages_en.properties Changed
    /src/.../service/RequisitionServiceTest.java Changed
    Open in IDE #permalink
    /src/.../testutils/RejectionDataBuilder.java Added
    Open in IDE #permalink
    /src/.../web/RequisitionControllerTest.java Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time