OLMIS-6858 Reporting stack to data-pump strategy

Activity

FEOLMIS-4117 9

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 28m 9 Feel free to notify anyone else who should look at this r...
    Reviewer - 0% reviewed      
    Reviewer - 100% reviewed 7m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed 0m    
    Reviewer - 34% reviewed 34m    
    Reviewer - 0% reviewed 1m    
    Total   1h 11m 9  
    #permalink

    Objectives

    • Review additional components in the docker-compose file.
    • Review new scripts and config files in the config/services/connect folder.
    • Review changes to the materialized views in the SQL file.
    • Review new/changed settings in the .env and settings-sample.env files.
    • Review removal of corresponding Nifi process groups.
    • Review new cron config folder.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Chongsun Ahn

    There are two main connectors for each service (referencedata and requisition...

    There are two main connectors for each service (referencedata and requisition), one source (e.g. source-requisition) and one sink (e.g. sink-requisition). The additional sink connectors are for tables that do not have a single id field defined as the primary key.

    Chongsun Ahn

    Feel free to notify anyone else who should look at this review.

    Feel free to notify anyone else who should look at this review.

    /reporting/config/.../connect/register.sh Added
    Open in IDE #permalink
    /reporting/.../connect/sink-orderable-identifiers.json Added
    Open in IDE #permalink
    /reporting/.../connect/sink-orderables.json Added
    Open in IDE #permalink
    /reporting/.../connect/sink-referencedata.json Added
    Open in IDE #permalink
    /reporting/.../connect/sink-requisition-group-members.json Added
    Open in IDE #permalink
    /reporting/.../connect/sink-requisition.json Added
    Open in IDE #permalink
    /reporting/.../connect/sink-supported-programs.json Added
    Open in IDE #permalink
    /reporting/.../connect/source-referencedata.json Added
    Open in IDE #permalink
    /reporting/.../connect/source-requisition.json Added
    Open in IDE #permalink
    /reporting/.../OpenLMIS/get-openlmis-v3-reference-geo-data.properties Deleted
    Open in IDE #permalink
    /reporting/.../OpenLMIS/materialized-views.properties Deleted
    Open in IDE #permalink
    /reporting/.../OpenLMIS/requisitions-connector.properties Deleted
    Open in IDE #permalink
    /reporting/.../OpenLMIS/superset-permissions.properties Deleted
    Open in IDE #permalink
    /reporting/.../datasources/database.yaml Changed 1
    Open in IDE #permalink
    /reporting/cron/periodic/15min/refresh-mv Added
    Open in IDE #permalink
    /reporting/cron/periodic/daily/.gitignore Added 1
    Open in IDE #permalink
    /reporting/cron/periodic/hourly/.gitignore Added
    Open in IDE #permalink
    /reporting/cron/.../monthly/.gitignore Added
    Open in IDE #permalink
    /reporting/cron/periodic/weekly/.gitignore Added
    Open in IDE #permalink
    /reporting/cron/Dockerfile Added
    Open in IDE #permalink
    /reporting/.../templates/OlmisCreateTableStatements.sql Changed 1
    Open in IDE #permalink
    /reporting/.env Changed 1
    Open in IDE #permalink
    /reporting/docker-compose.local.yml Added 1
    Open in IDE #permalink
    /reporting/docker-compose.yml Changed
    /reporting/settings-sample.env Changed 1
    /reporting/start-local.sh Added 1
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against