OLMIS-6761 Upgrade Spring Boot to 2.2.2

Activity

FEOLMIS-4040 0

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 6m    
    Reviewer - 0% reviewed 0m    
    Reviewer - Complete 9m    
    Total   15m 0  
    #permalink

    Objectives

    • Review regular Spring Boot 2.x changes.
    • Removing of migration tests and API key initializer test, since they are not useful now and require more work to maintain.
    • Spring Boot 2.x now requires specifying a password encoder, rather than just using the default. Since we don't have an encoder prefix for our passwords, using the NoOpPasswordEncoder. (https://spring.io/blog/2017/11/01/spring-security-5-0-0-rc1-released#password-encoding)

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/.../migration/BaseMigrationIntegrationTest.java Deleted
    Open in IDE #permalink
    /src/.../migration/RemoveReferenceDataUserIdFromUserMigrationIntegrationTest.java Deleted
    Open in IDE #permalink
    /src/.../repository/BaseCrudRepositoryIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/ApiKeyControllerIntegrationTest.java Changed
    /src/.../web/BaseWebIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/TokenIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/UserControllerIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../auth/ExposedMessageSourceIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../domain/ConditionalUuidGenerator.java Changed
    Open in IDE #permalink
    /src/main/java/.../auth/dto/PageDto.java Changed
    Open in IDE #permalink
    /src/.../security/SecurityConfiguration.java Changed
    Open in IDE #permalink
    /src/main/.../auth/service/UserService.java Changed
    Open in IDE #permalink
    /src/main/.../util/CustomSortDeserializer.java Changed
    Open in IDE #permalink
    /src/main/java/.../auth/util/Pagination.java Changed
    /src/main/.../auth/util/RequestHelper.java Changed
    Open in IDE #permalink
    /src/main/.../auth/web/ApiKeyController.java Changed
    /src/.../web/CustomWebMvcConfigurerAdapter.java Changed
    Open in IDE #permalink
    /src/main/.../auth/web/UserController.java Changed
    Open in IDE #permalink
    /src/main/.../auth/web/UserDtoValidator.java Changed
    Open in IDE #permalink
    /src/main/.../auth/ApiKeyInitializer.java Deleted
    Open in IDE #permalink
    /src/main/.../openlmis/auth/Application.java Changed
    Open in IDE #permalink
    /src/.../auth/ExportSchemaFlywayCallback.java Changed
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed
    Open in IDE #permalink
    /src/main/resources/application.properties Changed
    Open in IDE #permalink
    /src/.../domain/ConditionalUuidGeneratorTest.java Changed
    Open in IDE #permalink
    /src/.../service/AccessTokenServiceTest.java Changed
    Open in IDE #permalink
    /src/.../service/ExpirationTokenNotifierTest.java Changed
    Open in IDE #permalink
    /src/.../service/PasswordResetNotifierTest.java Changed
    Open in IDE #permalink
    /src/test/.../service/UserServiceTest.java Changed
    Open in IDE #permalink
    /src/.../util/CustomSortDeserializerTest.java Changed
    Open in IDE #permalink
    /src/test/.../auth/util/PaginationTest.java Added
    Open in IDE #permalink
    /src/.../web/PasswordResetRequestDtoValidatorTest.java Changed
    Open in IDE #permalink
    /src/test/.../web/UserDtoValidatorTest.java Changed
    Open in IDE #permalink
    /src/test/.../web/WebErrorHandlingTest.java Changed
    Open in IDE #permalink
    /src/test/.../auth/ApiKeyInitializerTest.java Deleted
    Open in IDE #permalink
    /src/.../auth/ExportSchemaFlywayCallbackTest.java Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed
    Open in IDE #permalink
    /Jenkinsfile Changed
    /build.gradle Changed
    Open in IDE #permalink
    /build.sh Changed
    Open in IDE #permalink
    /docker-compose.yml Changed
    Open in IDE #permalink
    /gradle.properties Changed
    Open in IDE #permalink
    /deployment/perftest_env/.env Changed
    /deployment/test_env/.env Changed
    /deployment/uat_env/.env Changed
    /.env Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against