OLMIS-6658 Removed joins checking if programOrderable for Ftap's program is...

Activity

FEOLMIS-4011 15

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 32m 4 Unfortunately according to the documentation, CriteriaBui...
    Reviewer - Complete 21m    
    Reviewer - 5% reviewed 26m 11 Can't we use the constant from the abstract class?
    Reviewer - Complete 27m    
    Total   1h 45m 15  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Paulina Buzderewicz

    Changelog reminder.

    Changelog reminder.

    /src/.../repository/FacilityTypeApprovedProductRepositoryIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../impl/FacilityTypeApprovedProductRepositoryImpl.java Changed 7
    Open in IDE #permalink
    /src/main/.../impl/IdentitiesSearchUtil.java Deleted 2
    Open in IDE #permalink
    /src/.../impl/IdentitiesSearchableRepository.java Added
    Open in IDE #permalink
    /src/.../impl/OrderableRepositoryImpl.java Changed
    /src/main/resources/api-definition.yaml Changed 3
    Open in IDE #permalink
    /CHANGELOG.md Changed 2
    Open in IDE #permalink
    /gradle.properties Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against