OLMIS-6358: Moved pagination options to request body

Activity

FEOLMIS-3868 2

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 7m 1 Feedback from QA: When using the POST facilityTypeApprov...
    Reviewer - Complete 6m    
    Reviewer - Complete 2m 1 What is the reason for this change?
    Reviewer - 0% reviewed      
    Total   15m 2  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Klaudia Pałkowska

    What is the reason for this change?

    What is the reason for this change?

    Łukasz Lewczyński

    Feedback from QA: When using the POST facilityTypeApprovedProducts endpoint,...

    Feedback from QA:

    When using the POST facilityTypeApprovedProducts endpoint, one can't search for FTAPs using only the access token, or only the access token and the page and size parameters. One also has to provide the body. Usually, I think we provide each parameter separately, or we provide only the body.

    /src/.../service/SupplyPartnerBuilder.java Changed
    /src/.../web/FacilityTypeApprovedProductController.java Changed
    /src/.../web/FacilityTypeApprovedProductSearchParams.java Changed
    /src/.../schemas/approvedProductSearchQuery.json Changed
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed
    /src/.../service/SupplyPartnerBuilderTest.java Changed
    /src/.../testbuilder/FacilityTypeApprovedProductSearchParamsDataBuilder.java Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against