OLMIS-6128: changed docker-dev version to 5.2

Activity

FEOLMIS-3745 5

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 41m 1 From what I know Łukasz Lewczyński introduced v5 with new...
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 21% reviewed 4m 1 Josh Zamor The intention is to have Gradle 5 eventually, ...
    Reviewer - Complete 3m    
    Reviewer - 18% reviewed 6m    
    Reviewer - Complete 6m 3 I'll resolve and I'll add some comments to openlmis/dev t...
    Total   1h 5  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Josh Zamor

    I'm a bit confused - v5 of this moved to Gradle 5, and then v5.2 bumped back ...

    I'm a bit confused - v5 of this moved to Gradle 5, and then v5.2 bumped back to gradle 4. That seems very confusing. Do we intend to remove v5? Does anything work correctly with v5?

    Josh Zamor

    When I say v5 of this, this == openlmis/dev

    When I say v5 of this, this == openlmis/dev

    Sebastian Brudziński

    Josh Zamor The intention is to have Gradle 5 eventually, however, none of our...

    Josh Zamor The intention is to have Gradle 5 eventually, however, none of our services currently work with Gradle 5. We have reverted this back to Gradle 4 in order to be able to roll a patch release that fixes translations, since there was a change in docker-dev as well.

    Mateusz Kwiatkowski

    From what I know Łukasz Lewczyński introduced v5 with new gradle version beca...

    From what I know Łukasz Lewczyński introduced v5 with new gradle version because it was required by a newer version of hapifhir so yes, it is used.
    https://github.com/OpenLMIS/openlmis-hapifhir/pull/2/files

    Josh Zamor

    I'll resolve and I'll add some comments to openlmis/dev that highlight why v5...

    I'll resolve and I'll add some comments to openlmis/dev that highlight why v5 has a newer version of Gradle than v5.2. I know someone will be confused by this in 6 months without it.

    /docker-compose.builder.yml Changed
    Open in IDE #permalink
    /docker-compose.override.yml Changed
    Open in IDE #permalink
    /docker-compose.builder.yml Changed
    Open in IDE #permalink
    /docker-compose.override.yml Changed
    Open in IDE #permalink
    /docker-compose.builder.yml Changed
    Open in IDE #permalink
    /docker-compose.override.yml Changed
    Open in IDE #permalink
    /docker-compose.builder.yml Changed
    Open in IDE #permalink
    /docker-compose.override.yml Changed
    Open in IDE #permalink
    /docker-compose.builder.yml Changed
    Open in IDE #permalink
    /docker-compose.override.yml Changed
    Open in IDE #permalink
    /docker-compose.builder.yml Changed
    Open in IDE #permalink
    /docker-compose.override.yml Changed
    Open in IDE #permalink
    /docker-compose.builder.yml Changed
    Open in IDE #permalink
    /docker-compose.override.yml Changed
    Open in IDE #permalink
    /docker-compose.builder.yml Changed
    /docker-compose.override.yml Changed
    Open in IDE #permalink
    /docker-compose.builder.yml Changed
    Open in IDE #permalink
    /docker-compose.override.yml Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against