OLMIS-5390 Update dev environment with Jasmine 2

Activity

FEOLMIS-3724 18

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 16m 4 I'm getting similar issues as Jasmine 1.x when making pro...
    Reviewer - Complete 21m 14 Please, add changelog entry mentioning jasmine upgrade.
    Reviewer - Complete 5m    
    Total   41m 18  
    #permalink

    Objectives

    This code has been pushed to a branch since it will fail most unit tests. But I would like this approach reviewed. If we are okay with updating lots of test to Jasmine 2, then I can make changes to the UI repos.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Chongsun Ahn

    The dev-ui files need to be reviewed for the upgrade to Jasmine 2.

    The dev-ui files need to be reviewed for the upgrade to Jasmine 2.

    Nikodem Graczewski

    Please, also update tests in other repositories.

    Please, also update tests in other repositories.

    Chongsun Ahn

    That will be done, but will be in a separate review.

    That will be done, but will be in a separate review.

    Nikodem Graczewski

    Please, add changelog entry mentioning jasmine upgrade.

    Please, add changelog entry mentioning jasmine upgrade.

    Chongsun Ahn

    I'm getting similar issues as Jasmine 1.x when making proposed changes. I don...

    I'm getting similar issues as Jasmine 1.x when making proposed changes. I don't think this is the right way to go, so I'm going to close this review.

    /Dockerfile Changed
    Open in IDE #permalink
    /npm-shrinkwrap.json Changed
    Open in IDE #permalink
    /package.json Changed
    Open in IDE #permalink
    /src/openlmis-adjustments/adjustments-modal.controller.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-adjustments/adjustments-modal.service.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-analytics/500.interceptor.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-analytics/analytics.service.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-analytics/buttons.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-analytics/state-change.interceptor.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-app-cache/openlmis-app-cache.controller.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-currency/openlmis-currency.service.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-database/local-database.spec.js Changed 13
    Open in IDE #permalink
    /src/openlmis-form/characters-left.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-form/input-control-invalid-children.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-form/input-control-invalid-compile.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-form/input-control-wrap.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-form/input.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-form/saving-indicator.controller.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-form/select-placeholder.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-form/select-select2.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-form/unique-id.service.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-i18n/message.service.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-invalid/openlmis-invalid.controller.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-invalid/openlmis-invalid.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-local-storage/local-storage.factory.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-locale/locale.controller.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-modal/alert.service.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-modal/confirm-modal.controller.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-modal/confirm.service.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-modal/loading-modal.service.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-modal/openlmis-modal.service.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-modal-state/openlmis-modal-state.provider.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-offline/offline-service.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-offline/offline.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-offline/offline.interceptor.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-pagination/openlmis-pagination.controller.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-pagination/openlmis-pagination.service.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-popover/popover-css.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-popover/popover-interactions.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-popover/popover-last-open.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-popover/popover-template.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-popover/popover-text.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-popover/popover-title.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-popover/popover.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-repository/openlmis-repository.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-repository/openlmis-resource.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-sort/openlmis-sort.controller.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-state-change-error/state-change-error.interceptor.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-state-tracker/state-tracker.service.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-table/openlmis-table-container-shortener.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-table/openlmis-table-pane.controller.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-table/openlmis-table-pane.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-table/openlmis-table-sticky-cell.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-table-filter/openlmis-table-filter-form.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-table-filter/openlmis-table-filters.controller.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-table-form/input-control-td-popover.directive.spec.js Changed
    Open in IDE #permalink
    /src/openlmis-table-form/td-openlmis-invalid-message.spec.js Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against