OLMIS-4531: Added compressing to HTTP POST responses

Activity

FEOLMIS-3705 4

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 35m 2 Sure, done.
    Reviewer - Complete 2m    
    Reviewer - Complete 17m 2 We should verify with the requisition service, but it doe...
    Reviewer - Complete 3m    
    Total   57m 4  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Sebastian Brudziński

    Two questions: *Why was it only added to the requisition service? *It seems...

    Two questions:

    • Why was it only added to the requisition service?
    • It seems that for GET requests we will now be doing double compression (on the application server and on reverse proxy); any way to avoid that?

    Klaudia Pałkowska

    1. The ticket states that compression should be tested on initiating a requis...

    1. The ticket states that compression should be tested on initiating a requisition, that's why it is currently added only to the requisition service.
    2. I think about disabling compression in nginx configuration.

    Sebastian Brudziński

    We should verify with the requisition service, but it doesn't mean we shouldn...

    We should verify with the requisition service, but it doesn't mean we shouldn't add to all of them. Thanks for doing so - I'd suggest adding the same to the template service, as it's expected that all services have this switched on.

    Klaudia Pałkowska

    Sure, done.

    Sure, done.

    /src/main/resources/application.properties Changed
    /CHANGELOG.md Changed
    /src/main/resources/application.properties Changed
    /CHANGELOG.md Changed
    /src/main/resources/application.properties Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /src/main/resources/application.properties Changed
    /CHANGELOG.md Changed
    /src/main/resources/application.properties Changed
    /CHANGELOG.md Changed
    /openlmis.conf Changed
    Open in IDE #permalink
    /src/main/resources/application.properties Changed
    /CHANGELOG.md Changed
    /src/main/resources/application.properties Changed
    /CHANGELOG.md Changed
    /src/main/resources/application.properties Changed
    /CHANGELOG.md Changed
    /src/main/resources/application.properties Changed
    /CHANGELOG.md Changed
    /src/main/resources/application.properties Changed
    /CHANGELOG.md Changed
    /src/main/resources/application.properties Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against