OLMIS-6056 implemented redis caching for getting supervisory node dto and...

Activity

FEOLMIS-3704 16

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1h 40m 3 As it is just a PoC, I don't think it is time for it now,...
    Reviewer - Complete 26m 12 Great work but we still should have separate interfaces f...
    Reviewer - 0% reviewed 5m    
    Reviewer - Complete 50m 1 Please change the hash key to "PROGRAM".
    Reviewer - Complete 1m    
    Total   3h 3m 16  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Łukasz Lewczyński

    One more thing. I am not sure if this should be done in this ticket or should...

    One more thing. I am not sure if this should be done in this ticket or should we have a new one but I should be able to control cache with the Cache-Control header.

    Paulina Mironiuk

    As it is just a PoC, I don't think it is time for it now, but it may be done ...

    As it is just a PoC, I don't think it is time for it now, but it may be done in next steps

    /performance/tests/supervisoryNodes.yml Added
    Open in IDE #permalink
    /src/.../repository/BaseRedisRepositoryIntegrationTest.java Deleted 1
    Open in IDE #permalink
    /src/.../repository/CrudRedisRepositoryIntegrationTest.java Added
    Open in IDE #permalink
    /src/.../repository/ProgramRedisRepositoryIntegrationTest.java Added 2
    Open in IDE #permalink
    /src/.../repository/SupervisoryNodeRedisRepositoryIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/BaseWebIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/ProgramControllerIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/SupervisoryNodeControllerIntegrationTest.java Changed
    Open in IDE #permalink
    /src/main/.../referencedata/dto/BaseDto.java Changed
    Open in IDE #permalink
    /src/main/.../impl/BaseRedisRepository.java Added
    Open in IDE #permalink
    /src/.../impl/BaseRedisRepositoryUtil.java Deleted
    Open in IDE #permalink
    /src/main/.../impl/ProgramRedisRepository.java Added
    Open in IDE #permalink
    /src/.../impl/ProgramRedisRepositoryImpl.java Deleted 3
    Open in IDE #permalink
    /src/.../impl/SupervisoryNodeDtoRedisRepository.java Added
    Open in IDE #permalink
    /src/.../impl/SupervisoryNodeDtoRedisRepositoryImpl.java Deleted
    Open in IDE #permalink
    /src/main/.../custom/BaseRedisRepository.java Deleted 1
    Open in IDE #permalink
    /src/main/.../custom/CrudRedisRepository.java Added
    Open in IDE #permalink
    /src/.../custom/ProgramRedisRepository.java Deleted 4
    Open in IDE #permalink
    /src/.../custom/SupervisoryNodeDtoRedisRepository.java Deleted 2
    Open in IDE #permalink
    /src/main/.../web/ProgramController.java Changed
    /src/.../web/SupervisoryNodeController.java Changed 1
    Open in IDE #permalink
    /src/main/.../referencedata/Application.java Changed
    Open in IDE #permalink
    /src/.../referencedata/AvailableFeatures.java Changed
    /CHANGELOG.md Changed
    /build.gradle Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against