OLMIS-5981: Updated /supervisoryNodes/{supervisoryNode_id} PUT to throw...

Activity

FEOLMIS-3697 3

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1h 11m    
    Reviewer - Complete 9m 1 I am not sure if this change is backward-compatible. I me...
    Reviewer - 52% reviewed 22m 2 Retrieve the requisitionGroup from the database, before y...
    Reviewer - 0% reviewed      
    Reviewer - Complete 16m    
    Total   1h 58m 3  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/.../referencedata/SupervisoryNodeStepDefs.java Changed
    Open in IDE #permalink
    /src/.../referencedata_tests/SupervisoryNodeTests.feature Changed
    Open in IDE #permalink
    /src/.../repository/RequisitionGroupRepositoryIntegrationTest.java Changed 1
    Open in IDE #permalink
    /src/.../web/RequisitionGroupControllerIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/SupervisoryNodeControllerIntegrationTest.java Changed
    /src/.../service/SupervisoryNodeBuilder.java Changed
    Open in IDE #permalink
    /src/main/.../messagekeys/MessageKeys.java Changed
    Open in IDE #permalink
    /src/.../messagekeys/SupervisoryNodeMessageKeys.java Changed
    Open in IDE #permalink
    /src/.../validate/SupervisoryNodeValidator.java Changed
    /src/.../web/SupervisoryNodeController.java Changed
    /src/main/resources/messages_en.properties Changed
    /src/.../service/SupervisoryNodeBuilderTest.java Changed
    Open in IDE #permalink
    /src/.../testbuilder/SupervisoryNodeDataBuilder.java Changed
    Open in IDE #permalink
    /src/.../validate/SupervisoryNodeValidatorTest.java Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed 2

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against