OLMIS-6055: Added rights per superset report

Activity

FEOLMIS-3675 14

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1h 9m 5 I'm not sure if I understand. I didn't remove any comment.
    Reviewer - Complete 2m    
    Reviewer - 54% reviewed 28m 6 FEOLMIS-3541
    Reviewer - Complete 25m 3 Is this method using permission strings?
    Reviewer - Complete 25m    
    Total   2h 29m 14  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Sebastian Brudziński

    The code looks good to me, but are we allowing to view all reports if I have ...

    The code looks good to me, but are we allowing to view all reports if I have one "VIew reports" global right?

    Klaudia Pałkowska

    No, we require a specific right to view a report.

    No, we require a specific right to view a report.

    Sebastian Brudziński

    We wanted the global view reports right to still grant access to ALL the reports

    We wanted the global view reports right to still grant access to ALL the reports

    /docker-compose.yml Changed
    /src/.../migration/20190304135759678__add_rights_per_report.sql Added 3
    Open in IDE #permalink
    /CHANGELOG.md Changed
    Open in IDE #permalink
    /src/admin-role-form/messages_en.json Changed 3
    /src/openlmis-rights/report-rights.constant.js Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed 2
    /src/report/report-list.controller.js Changed 2
    /src/report/report-list.controller.spec.js Changed
    Open in IDE #permalink
    /src/report/report-list.html Changed
    Open in IDE #permalink
    /src/report/report-list.routes.js Changed
    Open in IDE #permalink
    /src/report/report-list.routes.spec.js Added
    Open in IDE #permalink
    /src/report/report.factory.js Changed
    Open in IDE #permalink
    /src/report/report.factory.spec.js Changed
    Open in IDE #permalink
    /src/report/report.module.js Changed
    Open in IDE #permalink
    /src/report/superset-reports.constant.js Changed
    /CHANGELOG.md Changed 1
    /project.properties Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against