OLMIS-683: Update Orderables model to support Kits

Activity

FEOLMIS-3657 25

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1h 28m 7 ah. I did not know about "of" in EqualsAndHashCode. Ok, I...
    Reviewer - Complete 22m 12 from what I see we check if orderable and parent fields a...
    Reviewer - Complete 1h 10m 1 Maybe we should consider adding indexes here?
    Reviewer - Complete 39m 3 Thanks Elias!
    Reviewer - Complete 38m 2 How we typically have done this is to make this an Object...
    Total   4h 17m 25  
    #permalink

    Objectives

    69bd0c2f2d70a58e69d44384f34995b12a8f5dcc: OLMIS-683: Update Orderables model to support Kits

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Josh Zamor

    Thanks Elias, I added a comment on the API and I think Łukasz Lewczyński had ...

    Thanks Elias, I added a comment on the API and I think Łukasz Lewczyński had some good feedback. Let me know if you want to discuss the API in more depth.

    Elias

    Thanks everyone for the review and feedbacks. It is clear that the minimal-dt...

    Thanks everyone for the review and feedbacks. It is clear that the minimal-dto pattern is an anti pattern and I have replaced it with the ObjectReferenceDto.

    Josh Zamor

    Thanks Elias!

    Thanks Elias!

    /src/.../web/OrderableControllerIntegrationTest.java Changed
    /src/main/.../domain/Orderable.java Changed
    /src/main/.../domain/OrderableChild.java Added 5
    Open in IDE #permalink
    /src/main/.../dto/MinimalOrderableDto.java Deleted 3
    Open in IDE #permalink
    /src/main/.../dto/OrderableChildDto.java Added 7
    Open in IDE #permalink
    /src/main/.../dto/OrderableDto.java Changed
    /src/main/.../util/OrderableBuilder.java Changed 1
    /src/.../migration/20190213172821943__create_orderable_children.sql Added 4
    Open in IDE #permalink
    /src/main/.../schemas/minimalOrderable.json Deleted 1
    Open in IDE #permalink
    /src/main/resources/schemas/orderable.json Changed
    Open in IDE #permalink
    /src/main/.../schemas/orderableChildDto.json Added
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed
    /src/test/.../domain/OrderableChildTest.java Added 1
    Open in IDE #permalink
    /src/test/.../dto/MinimalOrderableDtoTest.java Deleted
    Open in IDE #permalink
    /src/test/.../dto/OrderableChildDtoTest.java Added
    Open in IDE #permalink
    /src/test/.../util/OrderableBuilderTest.java Changed
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against