OLMIS-5959: Make facility type input required on add template form

Activity

FEOLMIS-3646 20

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Ian
    Author 2h 1m 8 Already implemented as instructed here on commit OLMIS-59...
    Reviewer - Complete 46m 6 I don't see why we should move adding a simple separator ...
    Reviewer - Complete 29m 6 Feel free to close the review.
    Total   3h 16m 20  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Mateusz Kwiatkowski

    Please add changelog entry

    Please add changelog entry

    Ian

    Added on this commit (OLMIS-5959:Disable facility type add button until facil...

    Added on this commit (OLMIS-5959:Disable facility type add button until facility type is selected), also changed the logic instead of making facility type required i just disable add button because facility type is not supposed to be mandatory

    Mateusz Kwiatkowski

    Generally we are adding at least 2 people to reviews, I'll add Nikodem Gracze...

    Generally we are adding at least 2 people to reviews, I'll add Nikodem Graczewski since he is responsible for UI mostly

    Ian

    Noted, thank you

    Noted, thank you

    /src/admin-template-add/template-add-modal.html Changed 16
    Open in IDE #permalink
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against