OLMIS-5581: Rename CsvFileTemplate to FileTemplate, increased coverage on some...

Activity

FEOLMIS-3370 3

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 3m 1 No. There never was CsvColumn Builder. FileColumnBuilder ...
    Reviewer - Complete 9m 2 Do we also have CsvColumnBuilder that we need to remove?
    Reviewer - Complete 2m    
    Reviewer - 0% reviewed      
    Reviewer - Complete 11m    
    Total   25m 3  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /performance/tests/orderFileTemplate.yml Changed
    Open in IDE #permalink
    /src/.../web/BaseWebIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/CsvFileTemplateControllerIntegrationTest.java Deleted
    Open in IDE #permalink
    /src/.../web/FileTemplateControllerIntegrationTest.java Added
    Open in IDE #permalink
    /src/main/.../domain/CsvFileColumn.java Deleted
    Open in IDE #permalink
    /src/main/.../domain/CsvFileTemplate.java Deleted
    Open in IDE #permalink
    /src/main/.../domain/CsvTemplateType.java Deleted
    Open in IDE #permalink
    /src/main/.../domain/FileColumn.java Added
    Open in IDE #permalink
    /src/main/.../domain/FileTemplate.java Added
    Open in IDE #permalink
    /src/main/.../domain/TemplateType.java Added
    Open in IDE #permalink
    /src/main/.../i18n/MessageKeys.java Changed
    Open in IDE #permalink
    /src/.../repository/CsvFileColumnRepository.java Deleted
    Open in IDE #permalink
    /src/.../repository/CsvFileTemplateRepository.java Deleted
    Open in IDE #permalink
    /src/.../repository/FileColumnRepository.java Added
    Open in IDE #permalink
    /src/.../repository/FileTemplateRepository.java Added
    Open in IDE #permalink
    /src/.../service/CsvFileTemplateService.java Deleted
    Open in IDE #permalink
    /src/main/.../service/FileTemplateService.java Added
    Open in IDE #permalink
    /src/main/.../service/OrderCsvHelper.java Changed
    Open in IDE #permalink
    /src/main/.../service/OrderFileStorage.java Changed
    /src/main/.../web/util/CsvFileColumnDto.java Deleted
    Open in IDE #permalink
    /src/main/.../web/util/CsvFileTemplateDto.java Deleted
    Open in IDE #permalink
    /src/main/java/.../web/util/FileColumnDto.java Added
    Open in IDE #permalink
    /src/main/.../web/util/FileTemplateDto.java Added
    Open in IDE #permalink
    /src/.../validator/CsvFileTemplateValidator.java Deleted
    Open in IDE #permalink
    /src/.../validator/FileTemplateValidator.java Added
    Open in IDE #permalink
    /src/.../web/CsvFileTemplateController.java Deleted
    Open in IDE #permalink
    /src/main/.../web/FileTemplateController.java Added
    Open in IDE #permalink
    /src/main/.../web/OrderController.java Changed
    Open in IDE #permalink
    /src/.../web/OrderNumberConfigurationController.java Changed
    Open in IDE #permalink
    /src/.../migration/20181005182750366__change_order_file_configs_to_csv_file_config.sql Changed
    Open in IDE #permalink
    /src/main/.../schemas/csvFileColumnDto.json Deleted
    Open in IDE #permalink
    /src/main/.../schemas/csvFileTemplateDto.json Deleted
    Open in IDE #permalink
    /src/main/.../schemas/fileColumnDto.json Added
    Open in IDE #permalink
    /src/main/.../schemas/fileTemplateDto.json Added
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed
    /src/main/resources/logback.xml Changed 1
    Open in IDE #permalink
    /src/main/resources/messages_en.properties Changed
    Open in IDE #permalink
    /src/test/.../domain/CsvFileColumnTest.java Deleted
    Open in IDE #permalink
    /src/test/.../domain/CsvFileTemplateTest.java Deleted
    Open in IDE #permalink
    /src/test/.../domain/FileColumnTest.java Added
    Open in IDE #permalink
    /src/test/.../domain/FileTemplateTest.java Added
    Open in IDE #permalink
    /src/test/.../service/OrderCsvHelperTest.java Changed
    Open in IDE #permalink
    /src/test/.../service/OrderStorageTest.java Changed
    /src/test/.../util/CsvFileColumnDtoTest.java Deleted
    Open in IDE #permalink
    /src/test/.../util/CsvFileTemplateDtoTest.java Deleted
    Open in IDE #permalink
    /src/test/.../web/util/FileColumnDtoTest.java Added
    Open in IDE #permalink
    /src/test/.../util/FileTemplateDtoTest.java Added
    Open in IDE #permalink
    /src/.../fulfillment/CsvFileTemplateBuilder.java Deleted 2
    Open in IDE #permalink
    /src/.../fulfillment/FileColumnBuilder.java Added
    Open in IDE #permalink
    /src/.../fulfillment/FileTemplateBuilder.java Added
    Open in IDE #permalink
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against