OLMIS-5385: updated template service

Activity

FEOLMIS-3339 1

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 39m 1 I still need to fix 3 code smells from sonar. Two of them...
    Reviewer - Complete 15m    
    Reviewer - 0% reviewed      
    Reviewer - Complete 16m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 9% reviewed 38m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed 0m    
    Total   1h 49m 1  
    #permalink

    Objectives

    • change demo data loading approach to the new one
    • added some integration tests
    • added missing classes that are used by all services
    • added missing unit tests
    • update spring to the latest 1.X version
    • add importer/exporter pattern to a domain object
    • controller returns DTO not domain objects
    • update RAML
    • update dev image to the lastest one
    • added jenkinsfile
    • added migration test

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Łukasz Lewczyński

    I still need to fix 3 code smells from sonar. Two of them are related to miss...

    I still need to fix 3 code smells from sonar. Two of them are related to missing tests and one is related to fact that the class extends other class that has some tests but does not contain any test

    /demo-data/README.md Deleted
    Open in IDE #permalink
    /demo-data/demo_seed.sh Deleted
    Open in IDE #permalink
    /demo-data/demo_sql_footer.txt Deleted
    Open in IDE #permalink
    /demo-data/demo_sql_header.txt Deleted
    Open in IDE #permalink
    /demo-data/generator.js Deleted
    Open in IDE #permalink
    /demo-data/template.widget.json Deleted
    Open in IDE #permalink
    /src/.../i18n/ExposedMessageSourceIntegrationTest.java Added
    Open in IDE #permalink
    /src/.../migration/AddCodeFieldToWidgetMigrationIntegrationTest.java Added
    Open in IDE #permalink
    /src/.../migration/BaseMigrationIntegrationTest.java Added
    Open in IDE #permalink
    /src/.../repository/BaseCrudRepositoryIntegrationTest.java Added
    Open in IDE #permalink
    /src/.../repository/WidgetRepositoryIntegrationTest.java Added
    Open in IDE #permalink
    /src/.../web/BaseWebIntegrationTest.java Added
    Open in IDE #permalink
    /src/.../web/WidgetControllerIntegrationTest.java Added
    Open in IDE #permalink
    /src/.../template/JaVersIntegrationTest.java Changed
    Open in IDE #permalink
    /src/main/.../template/domain/BaseEntity.java Changed
    Open in IDE #permalink
    /src/.../domain/ConditionalUuidGenerator.java Added
    Open in IDE #permalink
    /src/.../domain/CustomPhysicalNamingStrategy.java Added
    Open in IDE #permalink
    /src/main/java/.../template/domain/Widget.java Changed
    Open in IDE #permalink
    /src/.../errorhandling/AbstractErrorHandling.java Changed
    Open in IDE #permalink
    /src/.../errorhandling/GlobalErrorHandling.java Changed
    Open in IDE #permalink
    /src/.../exception/BaseMessageException.java Changed
    Open in IDE #permalink
    /src/.../exception/ValidationMessageException.java Added
    Open in IDE #permalink
    /src/main/.../template/i18n/MessageKeys.java Changed
    Open in IDE #permalink
    /src/.../repository/BaseAuditableRepository.java Changed
    Open in IDE #permalink
    /src/.../security/CustomUserAuthenticationConverter.java Added
    Open in IDE #permalink
    /src/.../security/ResourceServerSecurityConfiguration.java Changed
    Open in IDE #permalink
    /src/.../util/ConditionalUuidGenerator.java Deleted
    Open in IDE #permalink
    /src/main/.../template/util/Pagination.java Changed
    Open in IDE #permalink
    /src/main/.../template/util/Resource2Db.java Added
    Open in IDE #permalink
    /src/main/.../web/widget/WidgetController.java Added
    Open in IDE #permalink
    /src/main/java/.../web/widget/WidgetDto.java Added
    Open in IDE #permalink
    /src/main/.../template/web/BaseController.java Changed
    Open in IDE #permalink
    /src/main/java/.../template/web/BaseDto.java Added
    Open in IDE #permalink
    /src/main/.../web/MessageController.java Deleted
    Open in IDE #permalink
    /src/main/.../web/WidgetController.java Deleted
    Open in IDE #permalink
    /src/main/.../template/Application.java Changed
    Open in IDE #permalink
    /src/.../template/AuditLogInitializer.java Changed
    /src/.../template/CustomWebMvcConfigurerAdapter.java Changed
    Open in IDE #permalink
    /src/.../template/ExportSchemaFlywayCallback.java Added
    Open in IDE #permalink
    /src/.../template/TestDataInitializer.java Added
    Open in IDE #permalink
    /src/main/resources/db/demo-data/README.md Added
    Open in IDE #permalink
    /src/main/.../db/demo-data/template.widget.csv Added
    Open in IDE #permalink
    /src/main/.../db/migration/.gitignore Deleted
    Open in IDE #permalink
    /src/.../migration/20170705125033654__initial_schema.sql Added
    Open in IDE #permalink
    /src/.../migration/20170705125033654__widget.sql Deleted
    Open in IDE #permalink
    /src/.../migration/20180927081245782__add_code_field_to_widget.sql Added
    Open in IDE #permalink
    /src/.../schemas/localizedErrorResponse.json Added
    Open in IDE #permalink
    /src/main/resources/schemas/widget.json Added
    Open in IDE #permalink
    /src/main/.../schemas/widgetPage.json Added
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed
    Open in IDE #permalink
    /src/.../resources/application-demo-data.properties Deleted
    Open in IDE #permalink
    /src/main/resources/application.properties Changed
    /src/main/resources/applicationContext.xml Deleted
    Open in IDE #permalink
    /src/main/resources/messages_en.properties Changed
    Open in IDE #permalink
    /src/test/.../domain/BaseEntityTest.java Added
    Open in IDE #permalink
    /src/.../domain/ConditionalUuidGeneratorTest.java Added
    Open in IDE #permalink
    /src/test/.../template/domain/WidgetTest.java Added
    Open in IDE #permalink
    /src/.../errorhandling/GlobalErrorHandlingTest.java Added
    Open in IDE #permalink
    /src/.../security/CustomUserAuthenticationConverterTest.java Added
    Open in IDE #permalink
    /src/.../security/ResourceServerSecurityConfigurationTest.java Added
    Open in IDE #permalink
    /src/test/.../template/util/MessageTest.java Added
    Open in IDE #permalink
    /src/test/.../util/PaginationTest.java Added
    Open in IDE #permalink
    /src/test/.../util/Resource2DbTest.java Added
    Open in IDE #permalink
    /src/test/.../web/widget/WidgetDtoTest.java Added
    Open in IDE #permalink
    /src/test/.../template/web/BaseDtoTest.java Added
    Open in IDE #permalink
    /src/.../template/AuditLogInitializerTest.java Added
    Open in IDE #permalink
    /src/.../template/ExportSchemaFlywayCallbackTest.java Added
    Open in IDE #permalink
    /src/.../template/TestDataInitializerTest.java Added
    Open in IDE #permalink
    /src/test/.../template/ToStringTestUtils.java Added
    Open in IDE #permalink
    /src/test/.../template/WidgetDataBuilder.java Added
    Open in IDE #permalink
    /src/test/.../template/WireMockTest.java Deleted
    Open in IDE #permalink
    /Dockerfile Changed
    /Jenkinsfile Added
    /build.gradle Changed
    /build.sh Changed
    Open in IDE #permalink
    /ci-buildImage.sh Added
    Open in IDE #permalink
    /ci-sonarAnalysis.sh Added
    Open in IDE #permalink
    /docker-compose.builder.yml Changed
    /docker-compose.override.yml Changed
    /export_schema.sh Added
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against