OLMIS-5226: Added sort parameter to requisitionsForApproval endpoint

Activity

FEOLMIS-3315 27

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1h 26m 15 I am going to resolve this comment and put that informati...
    Reviewer - 77% reviewed 21m 5 Could we add a test for null and empty set?
    Reviewer - Complete 11m    
    Reviewer - 27% reviewed 52m    
    Reviewer - Complete 23m    
    Reviewer - 82% reviewed 55m 7 See comment above; the name should be clear that it is so...
    Total   4h 7m 27  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/.../repository/BaseRequisitionRepositoryIntegrationTest.java Changed 2
    /src/.../repository/RequisitionRepositoryIntegrationTest.java Changed 4
    /src/.../web/RequisitionControllerIntegrationTest.java Changed
    /src/main/.../requisition/Requisition.java Changed
    /src/main/.../dto/RoleAssignmentDto.java Changed 1
    Open in IDE #permalink
    /src/.../impl/RequisitionRepositoryImpl.java Changed 7
    /src/.../referencedata/PeriodReferenceDataService.java Changed 2
    Open in IDE #permalink
    /src/.../referencedata/ProgramReferenceDataService.java Changed 2
    Open in IDE #permalink
    /src/main/.../service/RequisitionService.java Changed 1
    /src/.../web/BasicRequisitionDtoBuilder.java Changed 4
    Open in IDE #permalink
    /src/main/.../web/RequisitionController.java Changed
    /src/main/resources/api-definition.yaml Changed
    /src/.../referencedata/PeriodReferenceDataServiceTest.java Changed 2
    Open in IDE #permalink
    /src/.../referencedata/ProgramReferenceDataServiceTest.java Changed 2
    Open in IDE #permalink
    /src/.../service/RequisitionServiceTest.java Changed
    /src/.../testutils/UserDtoDataBuilder.java Changed
    Open in IDE #permalink
    /src/.../web/BasicRequisitionDtoBuilderTest.java Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against