FEOLMIS-3314 OLMIS-5389: Fixed ESLint Jasmine tech debts

closed on 14 Sep 18

Author

Reviewers

OLMIS-5389: Fixed ESLint Jasmine tech debts

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 31

openlmis-requisition-ui 0
- Folder src 0
  - Folder admin-program-add 0
    - File program-add.controller.spec.js 0 Remove
  - Folder admin-program-list 0
    - File program-administration-list.controller.spec.js 0 Remove
  - Folder admin-template 0
    - File template-validator.factory.spec.js 0 Remove
    - File template.spec.js 0 Remove
  - Folder admin-template-add 0
    - File template-add.controller.spec.js 0 Remove
  - Folder admin-template-configure-columns 0
    - File requisition-template-admin.controller.spec.js 0 Remove
    - File requisition-template.service.spec.js 0 Remove
  - Folder admin-template-configure-settings 0
    - File admin-template-configure-settings.controller.spec.js 0 Remove
    - File template-facility-type.factory.spec.js 0 Remove
  - Folder requisition 0
    - File requisition.spec.js 0 Remove
    - File requisitions.service.spec.js 0 Remove
  - Folder requisition-approval 0
    - File requisition-approval-list.controller.spec.js 0 Remove
  - Folder requisition-batch-approval 0
    - File requisition-batch-approval.controller.spec.js 0 Remove
    - File requisition-batch-approval.routes.spec.js 0 Remove
    - File requisition-batch-save.factory.spec.js 0 Remove
    - File validate-requisition.directive.spec.js 0 Remove
  - Folder requisition-calculations 0
    - File calculation.factory.spec.js 0 Remove
  - Folder requisition-convert-to-order 0
    - File convert-to-order.controller.spec.js 0 Remove
    - File convert-to-order.routes.spec.js 0 Remove
    - File requisitions-for-convert.factory.spec.js 0 Remove
  - Folder requisition-initiate 0
    - File period.factory.spec.js 0 Remove
    - File period.service.spec.js 0 Remove
    - File requisition-initiate.controller.spec.js 0 Remove
  - Folder requisition-losses-and-adjustments 0
    - File losses-and-adjustments.controller.spec.js 0 Remove
  - Folder requisition-product-grid 0
    - File product-grid-cell.directive.spec.js 0 Remove
  - Folder requisition-status-messages 0
    - File status-messages.controller.spec.js 0 Remove
  - Folder requisition-validation 0
    - File validation.factory.spec.js 0 Remove
  - Folder requisition-view 0
    - File requisition-view.controller.spec.js 0 Remove
    - File requisition-view.routes.spec.js 0 Remove
  - Folder requisition-view-tab 0
    - File add-full-supply-product-modal.controller.spec.js 0 Remove
    - File requisition-view-tab.controller.spec.js 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
Nikodem Graczewski	Author	0m
Łukasz Lewczyński	Reviewer - Complete	0m
Klaudia Pałkowska	Reviewer - Complete	5m
Mateusz Kwiatkowski	Reviewer - Complete	0m
Total		5m	0

Linked Issue:
OLMIS-5389

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-3314

OLMIS-5389: Fixed ESLint Jasmine tech debts

FEOLMIS-3314 0

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

OLMIS-5389: Fixed ESLint Jasmine tech debts

FEOLMIS-3314 0

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against