OLMIS-4943 fixed Jasper reports to use locale format settings - for report...

Activity
Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1h 24m 1 I've come to this conclusion after noticing that the repo...
    Reviewer - Complete 9m    
    Reviewer - 1% reviewed 6m 1 What about database migrations? I thought that editing jr...
    Reviewer - 2% reviewed 15m 1 Please add changelog.
    Reviewer - Complete 4m    
    Reviewer - 0% reviewed 0m    
    Total   1h 58m 3  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Klaudia Pałkowska

    Please add changelog.

    Please add changelog.

    Sebastian Brudziński

    What about database migrations? I thought that editing jrxml files is not eno...

    What about database migrations? I thought that editing jrxml files is not enough to have the report updated.

    Paulina Mironiuk

    I've come to this conclusion after noticing that the report is empty so I wil...

    I've come to this conclusion after noticing that the report is empty so I will update migrations.

    /src/.../web/JasperTemplateController.java Changed
    Open in IDE #permalink
    /src/.../migration/20180912071752646__update_pick_pack_list_report.sql Added
    Open in IDE #permalink
    /src/.../migration/20180912073952479__update_cce_alert_history_report.sql Added
    Open in IDE #permalink
    /src/.../migration/20180912074336103__update_facility_assignment_conf_errors_report.sql Added
    Open in IDE #permalink
    /src/.../migration/20180913070726171__update_cce_alert_history_report.sql Added
    Open in IDE #permalink
    /src/.../migration/20180913071005106__facility_assignment_configuration_errors_report.sql Added
    Open in IDE #permalink
    /src/.../migration/20180913071101429__local_fulfillment_pick_pack_list_report.sql Added
    Open in IDE #permalink
    /src/main/.../reports/cce_alert_history.jrxml Changed
    Open in IDE #permalink
    /src/.../reports/facility_assignment_configuration_errors.jrxml Changed
    Open in IDE #permalink
    /src/.../reports/local_fulfillment_pick_pack_list.jrxml Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against