OLMIS-5366: enabled average consumption column for SBR

Activity

FEOLMIS-3286 13

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 26m    
    Reviewer - Complete 26m 8 +1
    Reviewer - Complete 44m 5 Still doesn't seem correct or I'm missing something. Wher...
    Reviewer - 100% reviewed 1h 44m    
    Reviewer - 87% reviewed 18m    
    Reviewer - 0% reviewed      
    Total   3h 38m 13  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Łukasz Lewczyński

    missing changelog entries

    missing changelog entries

    /src/.../repository/RequisitionRepositoryIntegrationTest.java Changed
    /src/.../requisition/LineItemFieldsCalculator.java Changed 3
    Open in IDE #permalink
    /src/main/.../requisition/Requisition.java Changed
    /src/.../requisition/RequisitionLineItem.java Changed
    /src/.../dto/BasicProcessingPeriodDto.java Changed 1
    Open in IDE #permalink
    /src/main/.../dto/ProcessingPeriodDto.java Changed
    Open in IDE #permalink
    /src/main/.../dto/ProcessingScheduleDto.java Changed
    Open in IDE #permalink
    /src/.../referencedata/PeriodReferenceDataService.java Changed 1
    /src/main/.../service/PeriodService.java Changed 3
    Open in IDE #permalink
    /src/main/.../service/RequestParameters.java Changed
    Open in IDE #permalink
    /src/main/.../service/RequisitionService.java Changed
    /src/.../validate/RequisitionTemplateDtoValidator.java Changed
    /src/.../demo-data/requisition.columns_maps.csv Changed
    /src/.../migration/20180907113851465__added_stock_source_to_average_consumption_column.sql Added
    Open in IDE #permalink
    /src/test/.../requisition/RequisitionTest.java Changed
    /src/.../domain/LineItemFieldsCalculatorTest.java Changed
    Open in IDE #permalink
    /src/test/.../dto/ProcessingPeriodDtoTest.java Changed 4
    Open in IDE #permalink
    /src/.../referencedata/PeriodReferenceDataServiceTest.java Changed
    /src/test/.../service/PeriodServiceTest.java Changed
    Open in IDE #permalink
    /src/.../service/RequestParametersTest.java Changed
    Open in IDE #permalink
    /src/.../service/RequisitionServiceTest.java Changed
    /src/.../testutils/ProcessingPeriodDtoDataBuilder.java Added
    Open in IDE #permalink
    /src/.../testutils/ProcessingScheduleDtoDataBuilder.java Added
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /src/requisition-constants/template-columns.constant.js Changed
    /src/requisition-constants/template-columns.constant.spec.js Changed
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against