OpenLMIS

FEOLMIS-328

Join Review

Download Review as Text
View Review History

Keyboard Shortcuts

Tools

closed on 18 Oct 16

Author

Reviewers

Made demo data use actual UUIDs

Activity

FEOLMIS-328 2

Toggle Tree

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 31

openlmis-auth 0
- Folder demo-data 0
  - File auth.auth_users.json 0 Remove
openlmis-referencedata 0
- Folder demo-data 0
  - File referencedata.facilities.json 0 Remove
  - File referencedata.facility_operators.json 0 Remove
  - File referencedata.facility_type_approved_products.json 0 Remove
  - File referencedata.facility_types.json 2 Remove
  - File referencedata.geographic_levels.json 0 Remove
  - File referencedata.geographic_zones.json 0 Remove
  - File referencedata.orderable_products.json 0 Remove
  - File referencedata.processing_periods.json 0 Remove
  - File referencedata.processing_schedules.json 0 Remove
  - File referencedata.product_categories.json 0 Remove
  - File referencedata.program_products.json 0 Remove
  - File referencedata.programs.json 0 Remove
  - File referencedata.requisition_group_program_schedules.json 0 Remove
  - File referencedata.requisition_groups.json 0 Remove
  - File referencedata.rights.json 0 Remove
  - File referencedata.role_assignments.json 0 Remove
  - File referencedata.roles.json 0 Remove
  - File referencedata.supervisory_nodes.json 0 Remove
  - File referencedata.supply_lines.json 0 Remove
  - File referencedata.users.json 0 Remove
openlmis-requisition 0
- Folder demo-data 0
  - File requisition.columns_maps.json 0 Remove
  - File requisition.comments.json 0 Remove
  - File requisition.order_line_items.json 0 Remove
  - File requisition.order_number_configurations.json 0 Remove
  - File requisition.orders.json 0 Remove
  - File requisition.proof_of_deliveries.json 0 Remove
  - File requisition.proof_of_delivery_line_items.json 0 Remove
  - File requisition.requisition_line_items.json 0 Remove
  - File requisition.requisition_templates.json 0 Remove
  - File requisition.requisitions.json 0 Remove

1. Files
2. Comments
3. Defects
4. Diffs

Prefs
1. Source comments:
2. Inline
3. Above
4. Hidden
1. Side-by-side Diffs
2. Unified Diffs
1. Soft Wrapping
2. No Wrapping
1. Show Source

Filter
1. Only show me content:
1. that is unreviewed
2. that has a new or unread revision
1. with JIRA subtasks
2. with unresolved JIRA subtasks
1. Unfiltered files: dynamically added content
2. Filtered files: dynamically added content
3. Clear filters

Keyboard shortcuts

Summarize the review outcomes (optional)

Previewwiki syntax help

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Sebastian Brudziński	Author	4m	1	Fixed
Paweł Gesek	Reviewer - 0% reviewed	1m
Łukasz Lewczyński	Reviewer - Complete	6m	1	duplicate (line 3)
Total		11m	2

#permalink

Objectives

No, I don't expect you to verify that all UUIDs still form correct relationships.. just take a look I didn't miss anything

Branches in review

Repository	Branch to review	Branched from

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

/demo-data/auth.auth_users.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.facilities.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.facility_operators.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.facility_type_approved_products.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.facility_types.json Changed 2 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.geographic_levels.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.geographic_zones.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.orderable_products.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.processing_periods.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.processing_schedules.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.product_categories.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.program_products.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.programs.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.requisition_group_program_schedules.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.requisition_groups.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.rights.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.role_assignments.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.roles.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.supervisory_nodes.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.supply_lines.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/referencedata.users.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/requisition.columns_maps.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/requisition.comments.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/requisition.order_line_items.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/requisition.order_number_configurations.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/requisition.orders.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/requisition.proof_of_deliveries.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/requisition.proof_of_delivery_line_items.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/requisition.requisition_line_items.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/requisition.requisition_templates.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

/demo-data/requisition.requisitions.json Changed 0 (0)

FishEye

File Outdated
- View Latest

#permalink

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

Made demo data use actual UUIDs

FEOLMIS-328 2

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against