OLMIS-4980 Add report only flag to processing period

Activity

FEOLMIS-3148 12

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 12m 6 Done.
    Reviewer - 57% reviewed 3m 2 Would we make this class express state? In SMACSS-ish way...
    Reviewer - Complete 5m    
    Reviewer - Complete 14m 2 Thanks very much for the explanation! I didn't notice the...
    Reviewer - Complete 13m 2 I think that this field is used in getters for this class...
    Total   46m 12  
    #permalink

    Objectives

    • Review adding extra data field to processing period model, so that report only property can be added to period.
    • Review import/export of extra data for save and read.
    • Review UI addition of checkbox and table column for report only.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/main/.../domain/ProcessingPeriod.java Changed
    /src/main/.../dto/ProcessingPeriodDto.java Changed 4
    /src/.../migration/20180709205313168__add_extradata_to_processing_periods.sql Added
    Open in IDE #permalink
    /src/main/.../schemas/processingPeriod.json Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /src/admin-processing-schedule-edit/messages_en.json Changed
    Open in IDE #permalink
    /src/admin-processing-schedule-edit/processing-schedule-edit.html Changed 8
    /src/admin-processing-schedule-edit/processing-schedule.scss Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against