OLMIS-4923 Save notifications

Activity

FEOLMIS-3137 8

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 18m 3 Done.
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 87% reviewed 26m    
    Reviewer - Complete 20m 5 LGTM
    Reviewer - Complete 9m    
    Total   1h 12m 8  
    #permalink

    Objectives

    • Save notifications (using Importer pattern).
    • Move using notification and message DTOs to domain objects.
    • Move validation of notification channel to DTO validator, rather than handler.
    • Fix NPE with user from reference data being null, moving check from EmailNotificationChannelHandler to NotificationHandler, since we only need to check the user once.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Chongsun Ahn

    I know Nikodem and Łukasz are out this week, so I'm not sure who can review t...

    I know Nikodem and Łukasz are out this week, so I'm not sure who can review this. Feel free to add anyone who can.

    /src/.../repository/NotificationRepositoryIntegrationTest.java Changed 2
    /src/.../notification/NotificationControllerIntegrationTest.java Changed
    /src/main/.../domain/Notification.java Changed
    /src/main/.../domain/NotificationMessage.java Changed
    /src/main/.../i18n/MessageKeys.java Changed 3
    /src/.../service/EmailNotificationChannelHandler.java Changed
    /src/.../service/EmailVerificationNotifier.java Changed
    /src/.../service/NotificationChannelHandler.java Changed
    /src/main/.../service/NotificationHandler.java Changed 1
    /src/.../notification/NotificationController.java Changed
    /src/.../notification/NotificationDto.java Changed
    /src/.../notification/NotificationDtoValidator.java Changed
    /src/main/resources/messages_en.properties Changed
    /src/.../service/EmailNotificationChannelHandlerTest.java Changed
    /src/.../service/EmailVerificationNotifierTest.java Changed
    /src/.../service/NotificationHandlerTest.java Changed
    /src/.../util/NotificationDataBuilder.java Changed
    /src/.../notification/NotificationDtoValidatorTest.java Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against