FEOLMIS-3137 OLMIS-4923 Save notifications

closed on 05 Jul 18

Author

Reviewers

OLMIS-4923 Save notifications

Activity

Details
Objectives
General Comments 2
Unresolved
Resolved
Number of files included: 18

openlmis-notification 0
- Folder src 0
  - Folder integration-test/java/org/openlmis/notification 0
    - Folder repository 0
      - File NotificationRepositoryIntegrationTest.java 2 Remove
    - Folder web/notification 0
      - File NotificationControllerIntegrationTest.java 0 Remove
  - Folder main 0
    - Folder java/org/openlmis/notification 0
      - Folder domain 0
        
        File Notification.java 0 Remove
        
        File NotificationMessage.java 0 Remove
      - Folder i18n 0
        
        File MessageKeys.java 3 Remove
      - Folder service 0
        
        File EmailNotificationChannelHandler.java 0 Remove
        
        File EmailVerificationNotifier.java 0 Remove
        
        File NotificationChannelHandler.java 0 Remove
        
        File NotificationHandler.java 1 Remove
      - Folder web/notification 0
        
        File NotificationController.java 0 Remove
        
        File NotificationDto.java 0 Remove
        
        File NotificationDtoValidator.java 0 Remove
    - Folder resources 0
      - File messages_en.properties 0 Remove
  - Folder test/java/org/openlmis/notification 0
    - Folder service 0
      - File EmailNotificationChannelHandlerTest.java 0 Remove
      - File EmailVerificationNotifierTest.java 0 Remove
      - File NotificationHandlerTest.java 0 Remove
    - Folder util 0
      - File NotificationDataBuilder.java 0 Remove
    - Folder web/notification 0
      - File NotificationDtoValidatorTest.java 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Chongsun Ahn	Author	18m	3	Done.
Nikodem Graczewski	Reviewer - 0% reviewed
Łukasz Lewczyński	Reviewer - 0% reviewed
Sebastian Brudziński	Reviewer - 87% reviewed	26m
Mateusz Kwiatkowski	Reviewer - Complete	20m	5	LGTM
Jakub Kondrat	Reviewer - Complete	9m
Total		1h 12m	8

Linked Issue:
OLMIS-4923

#permalink

Objectives

Save notifications (using Importer pattern).
Move using notification and message DTOs to domain objects.
Move validation of notification channel to DTO validator, rather than handler.
Fix NPE with user from reference data being null, moving check from EmailNotificationChannelHandler to NotificationHandler, since we only need to check the user once.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Chongsun Ahn

I know Nikodem and Łukasz are out this week, so I'm not sure who can review t...

I know Nikodem and Łukasz are out this week, so I'm not sure who can review this. Feel free to add anyone who can.

02 Jul 18

Mateusz Kwiatkowski

LGTM

04 Jul 18

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-3137

OLMIS-4923 Save notifications

FEOLMIS-3137 8

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Chongsun Ahn

Mateusz Kwiatkowski

Log time against

OLMIS-4923 Save notifications

FEOLMIS-3137 8

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Chongsun Ahn

Mateusz Kwiatkowski

Log time against