FEOLMIS-3137 8
- Details
- Objectives
- General Comments 2
- Unresolved
- Resolved
- Number of files included: 18
-
openlmis-notification
0
-
Folder
src
0
-
Folder
integration-test/java/org/openlmis/notification
0
-
Folder
repository
0
- File NotificationRepositoryIntegrationTest.java 2 Remove
-
Folder
web/notification
0
- File NotificationControllerIntegrationTest.java 0 Remove
-
Folder
repository
0
-
Folder
main
0
-
Folder
java/org/openlmis/notification
0
-
Folder
domain
0
- File Notification.java 0 Remove
- File NotificationMessage.java 0 Remove
-
Folder
i18n
0
- File MessageKeys.java 3 Remove
-
Folder
service
0
- File EmailNotificationChannelHandler.java 0 Remove
- File EmailVerificationNotifier.java 0 Remove
- File NotificationChannelHandler.java 0 Remove
- File NotificationHandler.java 1 Remove
-
Folder
web/notification
0
- File NotificationController.java 0 Remove
- File NotificationDto.java 0 Remove
- File NotificationDtoValidator.java 0 Remove
-
Folder
domain
0
-
Folder
resources
0
- File messages_en.properties 0 Remove
-
Folder
java/org/openlmis/notification
0
-
Folder
test/java/org/openlmis/notification
0
-
Folder
service
0
- File EmailNotificationChannelHandlerTest.java 0 Remove
- File EmailVerificationNotifierTest.java 0 Remove
- File NotificationHandlerTest.java 0 Remove
-
Folder
util
0
- File NotificationDataBuilder.java 0 Remove
-
Folder
web/notification
0
- File NotificationDtoValidatorTest.java 0 Remove
-
Folder
service
0
-
Folder
integration-test/java/org/openlmis/notification
0
-
Folder
src
0
-
Filter
- Only show me content:
- Unfiltered files: dynamically added content
- Filtered files: dynamically added content
- Clear filters
Keyboard shortcuts
Summarize the review outcomes (optional)
#permalink
Details
#permalink
Objectives
- Save notifications (using Importer pattern).
- Move using notification and message DTOs to domain objects.
- Move validation of notification channel to DTO validator, rather than handler.
- Fix NPE with user from reference data being null, moving check from EmailNotificationChannelHandler to NotificationHandler, since we only need to check the user once.
Branches in review
Repository | Branch to review | Branched from |
---|
/src/.../repository/NotificationRepositoryIntegrationTest.java
Changed
2
(0)
/src/.../notification/NotificationControllerIntegrationTest.java
Changed
0
(0)
/src/main/.../domain/Notification.java
Changed
0
(0)
/src/main/.../domain/NotificationMessage.java
Changed
0
(0)
/src/main/.../i18n/MessageKeys.java
Changed
3
(0)
/src/.../service/EmailNotificationChannelHandler.java
Changed
0
(0)
/src/.../service/EmailVerificationNotifier.java
Changed
0
(0)
/src/.../service/NotificationChannelHandler.java
Changed
0
(0)
/src/main/.../service/NotificationHandler.java
Changed
1
(0)
/src/.../notification/NotificationController.java
Changed
0
(0)
/src/.../notification/NotificationDto.java
Changed
0
(0)
/src/.../notification/NotificationDtoValidator.java
Changed
0
(0)
/src/main/resources/messages_en.properties
Changed
0
(0)
/src/.../service/EmailNotificationChannelHandlerTest.java
Changed
0
(0)
/src/.../service/EmailVerificationNotifierTest.java
Changed
0
(0)
/src/.../service/NotificationHandlerTest.java
Changed
0
(0)
/src/.../util/NotificationDataBuilder.java
Changed
0
(0)
/src/.../notification/NotificationDtoValidatorTest.java
Changed
0
(0)
I know Nikodem and Łukasz are out this week, so I'm not sure who can review this. Feel free to add anyone who can.