OLMIS-4907: moved verification feature to notification service (auth service)

Activity

FEOLMIS-3099 2

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 8m 1 I thought I removed the entry but not so I did it now htt...
    Reviewer - Complete 2m    
    Reviewer - Complete 9m 1 Does this change require some modifications in CHANGELOG?
    Total   19m 2  
    #permalink

    Objectives

    Removed all code that were related with verification feature

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Mateusz Kwiatkowski

    Does this change require some modifications in CHANGELOG?

    Does this change require some modifications in CHANGELOG?

    Łukasz Lewczyński

    I thought I removed the entry but not so I did it now https://review.openlmis...

    I thought I removed the entry but not so I did it now

    /src/.../repository/EmailVerificationTokenRepositoryIntegrationTest.java Deleted
    Open in IDE #permalink
    /src/.../web/UserControllerIntegrationTest.java Changed
    /src/.../domain/EmailVerificationToken.java Deleted
    Open in IDE #permalink
    /src/.../dto/EmailVerificationTokenDto.java Deleted
    Open in IDE #permalink
    /src/main/java/.../auth/i18n/MessageKeys.java Changed
    /src/.../repository/EmailVerificationTokenRepository.java Deleted
    Open in IDE #permalink
    /src/.../service/EmailVerificationNotifier.java Deleted
    Open in IDE #permalink
    /src/main/.../service/PermissionService.java Changed
    /src/main/.../auth/service/UserService.java Changed
    /src/main/.../auth/web/UserController.java Changed
    /src/main/.../auth/web/WebErrorHandling.java Changed
    /src/.../migration/20180607110415124__added_email_verification_tokens.sql Deleted
    Open in IDE #permalink
    /src/.../schemas/emailVerificationToken.json Deleted
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed
    /src/main/resources/messages_en.properties Changed
    /src/.../domain/EmailVerificationTokenTest.java Deleted
    Open in IDE #permalink
    /src/.../dto/EmailVerificationTokenDtoTest.java Deleted
    Open in IDE #permalink
    /src/.../service/EmailVerificationNotifierTest.java Deleted
    Open in IDE #permalink
    /src/.../service/PermissionServiceTest.java Changed
    Open in IDE #permalink
    /src/test/.../service/UserServiceTest.java Changed
    /src/test/.../web/WebErrorHandlingTest.java Changed
    /src/.../auth/EmailVerificationTokenDataBuilder.java Deleted
    Open in IDE #permalink
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against