OLMIS-3162: Make periodsForInitiate sufficient to determine available periods

Activity

FEOLMIS-3091 3

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 25m    
    Reviewer - Complete 2m 1 equals, hashcode, toString + tests of course https://revi...
    Reviewer - Complete 18m 2 Were the deploy repos / contract tests etc. updated with ...
    Reviewer - Complete 42m    
    Total   1h 27m 3  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /.env Changed
    /deployment/perftest_env/.env Changed
    /deployment/test_env/.env Changed
    /deployment/uat_env/.env Changed
    /.env Changed
    /src/.../dto/BasicProcessingPeriodDto.java Changed
    /src/main/.../dto/ProcessingPeriodDto.java Changed
    /src/main/.../dto/RequisitionPeriodDto.java Changed 1
    /src/main/.../service/PeriodService.java Changed
    /src/main/.../web/RequisitionController.java Changed
    /src/.../schemas/requisitionPeriodDto.json Changed 1
    Open in IDE #permalink
    /src/.../dto/BasicProcessingPeriodDtoTest.java Added
    Open in IDE #permalink
    /src/test/.../dto/ProcessingPeriodDtoTest.java
    /src/.../dto/RequisitionPeriodDtoTest.java Added
    Open in IDE #permalink
    /src/test/.../service/PeriodServiceTest.java Changed
    /src/.../web/RequisitionControllerTest.java Changed
    /CHANGELOG.md Changed 1
    /gradle.properties Changed
    /src/requisition-initiate/period.factory.js Changed
    /src/requisition-initiate/period.factory.spec.js Changed
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against