OLMIS-4896: renamed user resources

Activity

FEOLMIS-3056 5

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 29m 3 renamed it
    Reviewer - Complete 5m 1 To be sure: this is just about renaming the class?
    Reviewer - 26% reviewed 9m 1 Thanks for this. As I think about it more, I am thinking ...
    Total   43m 5  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Mateusz Kwiatkowski

    To be sure: this is just about renaming the class?

    To be sure: this is just about renaming the class?

    Chongsun Ahn

    Thanks for this. As I think about it more, I am thinking that a DTO that is a...

    Thanks for this. As I think about it more, I am thinking that a DTO that is a superset of properties between auth, reference data and notification will just be a UserDto. The reference data specific ones would be something like UserMainDetailsDto (not UserDetailsDto because that might get confused with Spring's UserDetailsService), the one for auth would be UserAuthDetailsDto or UserCredentialsDto, and the one for notification (which would have email address and phone number) would be UserContactDetailsDto. What do you think?

    Łukasz Lewczyński

    I renamed reference data user dto to UserMainDetailsDto and dto that is a sup...

    I renamed reference data user dto to UserMainDetailsDto and dto that is a superset of properties to UserDto. Currently we don't have dto for auth user (we don't return it by endpoints), and for notification service.

    /src/.../web/ApiKeyControllerIntegrationTest.java Changed
    /src/.../web/TokenIntegrationTest.java Changed
    /src/.../web/UserControllerIntegrationTest.java Changed
    /src/main/.../dto/referencedata/UserDto.java Deleted
    Open in IDE #permalink
    /src/.../referencedata/UserMainDetailsDto.java Added
    Open in IDE #permalink
    /src/main/java/.../auth/dto/UserDto.java
    /src/main/.../auth/dto/UserSaveRequest.java Deleted
    Open in IDE #permalink
    /src/main/.../dto/UserWithAuthDetailsDto.java Deleted
    Open in IDE #permalink
    /src/.../referencedata/UserReferenceDataService.java Changed
    /src/.../service/ExpirationTokenNotifier.java Changed
    /src/main/.../service/PermissionService.java Changed
    /src/main/.../auth/service/UserService.java Changed
    /src/main/.../util/AuthenticationHelper.java Changed
    /src/main/.../auth/web/ApiKeyController.java Changed
    /src/main/.../auth/web/UserController.java Changed
    /src/main/.../auth/web/UserDtoValidator.java Added
    Open in IDE #permalink
    /src/.../web/UserSaveRequestValidator.java Deleted
    Open in IDE #permalink
    /src/.../web/UserWithAuthDetailsDtoValidator.java Deleted 1
    Open in IDE #permalink
    /src/test/.../referencedata/BaseDtoTest.java Changed
    /src/test/.../referencedata/UserDtoTest.java Deleted
    Open in IDE #permalink
    /src/.../referencedata/UserMainDetailsDtoTest.java Added
    Open in IDE #permalink
    /src/test/java/.../auth/dto/UserDtoTest.java Added
    Open in IDE #permalink
    /src/test/.../dto/UserSaveRequestTest.java Deleted
    Open in IDE #permalink
    /src/.../dto/UserWithAuthDetailsDtoTest.java Deleted
    Open in IDE #permalink
    /src/.../referencedata/UserReferenceDataServiceTest.java Changed
    /src/.../service/ExpirationTokenNotifierTest.java Changed
    /src/.../service/PermissionServiceTest.java Changed
    /src/test/.../service/UserServiceTest.java Changed
    /src/.../util/AuthenticationHelperTest.java Changed
    /src/test/.../web/UserDtoValidatorTest.java Added
    /src/.../web/UserSaveRequestValidatorTest.java Deleted
    Open in IDE #permalink
    /src/.../web/UserWithAuthDetailsDtoValidatorTest.java Deleted
    Open in IDE #permalink
    /src/test/.../openlmis/auth/DummyUserDto.java Deleted
    Open in IDE #permalink
    /src/.../auth/DummyUserMainDetailsDto.java Added
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against