OLMIS-4896: Made same ids for auth and reference data users

Activity

FEOLMIS-3055 34

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1h 4m 16 I put it in methods
    Reviewer - 75% reviewed 8m    
    Reviewer - Complete 21m 3 Should this be async? What if sending notification fails ...
    Reviewer - 0% reviewed      
    Reviewer - Complete 1h 15 This, and request.getEmail() could be hasEmailAddress and...
    Total   2h 33m 34  
    #permalink

    Objectives

    To resolve issue with data consistent from https://review.openlmis.org/cru/FEOLMIS-3032#c18177 I decided to removed the referenceDataUserId field from the auth's user resource and use the same ID value for the auth's user and reference data's user.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Łukasz Lewczyński

    Note: there is a changelog entry for the OLMIS-4896

    Note: there is a changelog entry for the OLMIS-4896

    Chongsun Ahn

    Can you explain how this ensures saving the user is a "transaction"?

    Can you explain how this ensures saving the user is a "transaction"?

    Łukasz Lewczyński

    I removed referenceDataUserId from the auth's user class and made that user i...

    I removed referenceDataUserId from the auth's user class and made that user instances in both services have the same ID field. Thanks that I don't have to wait for response from the reference data and I could put this statement to the end of user save process

    Chongsun Ahn

    I know this review is focused on changing user ids, but I made a number of co...

    I know this review is focused on changing user ids, but I made a number of comments on the code.

    /demo-data/auth.auth_users.json Changed
    /src/.../repository/UserRepositoryIntegrationTest.java Changed
    /src/.../web/UserControllerIntegrationTest.java Changed
    /src/main/java/.../auth/domain/User.java Changed
    /src/main/java/.../auth/dto/UserDto.java Changed
    /src/main/java/.../auth/i18n/MessageKeys.java Changed
    /src/main/.../repository/UserRepository.java Changed 2
    /src/.../security/AccessTokenEnhancer.java Changed
    /src/.../service/EmailVerificationNotifier.java Changed 9
    /src/.../service/ExpirationTokenNotifier.java Changed
    /src/.../service/UserDetailsServiceImpl.java Changed 2
    /src/main/.../auth/service/UserService.java Changed 17
    /src/main/.../util/AuthenticationHelper.java Changed
    /src/main/.../auth/web/UserController.java Changed
    /src/.../web/UserSaveRequestValidator.java Changed
    /src/.../migration/20180613120215847__remove_referencedatauserid_from_user.sql Added
    Open in IDE #permalink
    /src/main/resources/messages_en.properties Changed
    /src/test/java/.../auth/dto/UserDtoTest.java Changed
    /src/.../service/UserDetailsServiceImplTest.java Added
    Open in IDE #permalink
    /src/test/.../service/UserServiceTest.java Changed
    /src/.../web/UserSaveRequestValidatorTest.java Changed
    /src/test/.../openlmis/auth/DummyUserDto.java Changed
    /src/.../auth/OAuth2AuthenticationDataBuilder.java Changed
    /src/test/.../auth/UserDataBuilder.java Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against