OLMIS-4833: Extracted notifier functionality to separate classes

Activity

FEOLMIS-3054 9

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 17m 5 we don't use this notifier when we save user so we don't ...
    Reviewer - Complete 10m 3 Could we somehow move isNewUser part of the User class? I...
    Reviewer - Complete 12m 1 why this isn't @Async ?
    Total   38m 9  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Łukasz Lewczyński

    functionality was not changed. I only moved them from service to new classes

    functionality was not changed. I only moved them from service to new classes

    /src/.../web/UserControllerIntegrationTest.java Changed
    /src/main/java/.../auth/i18n/MessageKeys.java Changed
    /src/.../service/EmailVerificationNotifier.java Added 4
    /src/.../service/ExpirationTokenNotifier.java Added
    Open in IDE #permalink
    /src/.../service/PasswordResetNotifier.java Added 4
    /src/main/.../auth/service/UserService.java Changed
    /src/main/.../auth/web/UserController.java Changed
    /src/main/resources/messages_en.properties Changed
    /src/test/.../auth/i18n/MessageKeysTest.java Changed
    /src/test/.../service/BaseServiceTest.java Deleted
    Open in IDE #permalink
    /src/.../service/EmailVerificationNotifierTest.java Added
    Open in IDE #permalink
    /src/.../service/ExpirationTokenNotifierTest.java Added
    Open in IDE #permalink
    /src/.../service/PasswordResetNotifierTest.java Added
    /src/test/.../service/UserServiceTest.java Changed
    /src/test/.../openlmis/auth/SaveAnswer.java Added
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against