OLMIS-3415: Support NPM dependencies

Activity

FEOLMIS-3050 18

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 56m 10 It's created by yarn
    Reviewer - Complete 21m 8 Where is the bower_components dir coming from now?
    Reviewer - Complete 12m    
    Total   1h 28m 18  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Jakub Kondrat

    Here's a proposed solution: I modified our existing tasks in dev-ui to suppor...

    Here's a proposed solution: I modified our existing tasks in dev-ui to support npm dependencies. It's not a perfect one - we are still using wiredep which is designed for bower. An alternative is to use webpack or browserify to bundle our files, which would require a lot more work and possibly refactoring the code. After migrating all the dependencies, we could completely remove bower. Please let me know what do you think about it and if I should continue migrating all the services.

    Nikodem Graczewski

    Perhaps we should give yarn a try as migrating solely to npm seems problematic.

    Perhaps we should give yarn a try as migrating solely to npm seems problematic.

    Nikodem Graczewski

    Other approach we could take is switching to webpack completely, but it might...

    Other approach we could take is switching to webpack completely, but it might be really painful... We could cheese it a bit and postpone adding require everywhere but using require.context, but it would still be a significant amount of work to do, but most likely only here.

    Nikodem Graczewski

    And, to be honest, it's something I would love to tackle personally.

    And, to be honest, it's something I would love to tackle personally.

    Jakub Kondrat

    I agree that we should ultimately use webpack instead of bundling dependencie...

    I agree that we should ultimately use webpack instead of bundling dependencies ourselves. I'll try using yarn for now. Unlike npm, it seems to be capable of getting single js files (analytics.js)

    /tasks/assets.js Changed
    Open in IDE #permalink
    /tasks/bower.js Deleted
    Open in IDE #permalink
    /tasks/css.js Changed 7
    Open in IDE #permalink
    /tasks/default.js Changed
    Open in IDE #permalink
    /tasks/javascript.js Changed
    /tasks/karma.js Changed 1
    /tasks/npm.js Deleted 3
    Open in IDE #permalink
    /tasks/yarn.js Added
    /Dockerfile Changed
    /README.md Changed
    Open in IDE #permalink
    /bower.json Deleted
    Open in IDE #permalink
    /package-yarn.json Added
    Open in IDE #permalink
    /package.json Changed
    /Dockerfile Changed
    Open in IDE #permalink
    /bower.json Deleted
    Open in IDE #permalink
    /package-yarn.json Added
    Open in IDE #permalink
    /Dockerfile Changed
    Open in IDE #permalink
    /bower.json Deleted
    Open in IDE #permalink
    /package-yarn.json Added
    Open in IDE #permalink
    /bower.json Deleted
    Open in IDE #permalink
    /package-yarn.json Added
    Open in IDE #permalink
    /Dockerfile Changed
    Open in IDE #permalink
    /bower.json Deleted
    Open in IDE #permalink
    /package-yarn.json Added
    Open in IDE #permalink
    /Dockerfile Changed
    Open in IDE #permalink
    /bower.json Deleted
    Open in IDE #permalink
    /package-yarn.json Added
    Open in IDE #permalink
    /Dockerfile Changed
    Open in IDE #permalink
    /bower.json Deleted 1
    Open in IDE #permalink
    /package-yarn.json Added
    Open in IDE #permalink
    /package.json Changed 1
    /Dockerfile Changed
    Open in IDE #permalink
    /bower.json Deleted
    Open in IDE #permalink
    /package-yarn.json Added
    /Dockerfile Changed
    Open in IDE #permalink
    /bower.json Deleted
    Open in IDE #permalink
    /package-yarn.json Added
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against