OLMIS-3288 - Expose rest endpoint for reports processing period filter

Activity

FEOLMIS-3049 14

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 2h 3m 3 This is because the existing implementation for fetching ...
    Reviewer - Complete 36m 4 if everything was removed, does this entry is still valid?
    Reviewer - 93% reviewed 20m 1 I don't understand why we would want to retrieve processi...
    Reviewer - Complete 19m 6 Can we also remove this message from ProcessingMessageKey...
    Reviewer - Complete 13m    
    Total   3h 31m 14  
    #permalink

    Objectives

    Please review my work for ticket OLMIS-3288. Thanks

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Łukasz Lewczyński

    missing changelog about new endpoint in the reference data service

    missing changelog about new endpoint in the reference data service

    Adugna Worku

    The new endpoint has been removed.

    The new endpoint has been removed.

    /src/.../service/ProcessingPeriodSearchParams.java Changed 1
    /src/.../service/ProcessingPeriodService.java Changed 2
    /src/.../messagekeys/ProcessingPeriodMessageKeys.java Changed
    /src/.../web/ProcessingPeriodController.java Changed 6
    /src/main/resources/messages_en.properties Changed
    /src/.../service/ProcessingPeriodSearchParamsTest.java Changed
    /src/.../messagekeys/ProcessingPeriodMessageKeysTest.java Changed
    /CHANGELOG.md Changed 2
    /src/report/report-generate.controller.js Changed
    /CHANGELOG.md Changed
    /demo-data/generator.js Changed
    /demo-data/requisition.jasper_template_parameter_dependencies.json Added
    /demo-data/requisition.template_parameters.json Changed 1
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against