Fixed some tech debt and standardized formating in preparation for updated...

Activity

FEOLMIS-3033 4

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 4m 2 Fixed in FEOLMIS-3291.
    Reviewer - Complete 28m    
    Reviewer - Complete 19m    
    Reviewer - Complete 16m 2 this should be in dev-ui
    Total   1h 6m 4  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/openlmis-adjustments/adjustments-modal.controller.js Changed
    Open in IDE #permalink
    /src/openlmis-adjustments/adjustments-modal.html Changed
    Open in IDE #permalink
    /src/openlmis-adjustments/adjustments-modal.service.js Changed
    Open in IDE #permalink
    /src/openlmis-analytics/analytics.service.js Changed
    Open in IDE #permalink
    /src/openlmis-analytics/buttons.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-analytics/state-change.interceptor.js Changed
    Open in IDE #permalink
    /src/openlmis-app-cache/openlmis-app-cache.controller.js Changed
    Open in IDE #permalink
    /src/openlmis-config/FormData.js Changed
    Open in IDE #permalink
    /src/openlmis-config/perfect-scrollbar.factory.js Changed 2
    Open in IDE #permalink
    /src/openlmis-config/pouch-db.constant.js Changed
    Open in IDE #permalink
    /src/openlmis-config/resize-observer.factory.js Changed
    Open in IDE #permalink
    /src/openlmis-config/shortid.js Changed
    Open in IDE #permalink
    /src/openlmis-currency/openlmis-currency.filter.js Changed
    /src/openlmis-currency/openlmis-currency.module.js Changed
    /src/openlmis-currency/openlmis-currency.service.js Changed
    Open in IDE #permalink
    /src/openlmis-database/local-database.js Changed
    /src/openlmis-date/date-format-translator.js Changed
    Open in IDE #permalink
    /src/openlmis-date/date-utils.factory.js Changed
    /src/openlmis-date/iso-date.filter.js Changed
    Open in IDE #permalink
    /src/openlmis-date/moment.constant.js Changed
    Open in IDE #permalink
    /src/openlmis-date/openlmis-date.filter.js Changed
    /src/openlmis-date/openlmis-datetime.filter.js Changed
    /src/openlmis-date/period.filter.js Changed
    /src/openlmis-external-url/openlmis-external-url.module.js Changed
    Open in IDE #permalink
    /src/openlmis-external-url/openlmis-external-url.run.js Changed
    Open in IDE #permalink
    /src/openlmis-facility/facility.filter.js Changed
    Open in IDE #permalink
    /src/openlmis-file-upload/openlmis-file-upload.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-form/character-length.controller.js Changed
    Open in IDE #permalink
    /src/openlmis-form/characters-left.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-form/form-invalid-hide.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-form/form-novalidate.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-form/form-server-validation.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-form/form-toolbar.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-form/form-validate-submit.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-form/input-control-invalid-children.js Changed
    Open in IDE #permalink
    /src/openlmis-form/input-control-invalid-compile.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-form/input-control-invalid.directive.js Changed
    /src/openlmis-form/input-control-wrap.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-form/input-control.controller.js Changed
    Open in IDE #permalink
    /src/openlmis-form/input-control.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-form/input-group-fieldset-invalid.js Changed
    Open in IDE #permalink
    /src/openlmis-form/input-group-fieldset-required.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-form/input-group-fieldset.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-form/input-required.directive.js Changed
    /src/openlmis-form/input.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-form/openlmis-datepicker.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-form/positive-integer.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-form/saving-indicator.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-form/select-one-option.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-form/select-placeholder.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-form/select-select2.directive.js Changed
    /src/openlmis-form/unique-id.service.js Changed
    /src/openlmis-i18n/message.filter.js Changed
    Open in IDE #permalink
    /src/openlmis-i18n/message.service.js Changed
    /src/openlmis-invalid/ngmodel-openlmis-invalid.directive.js Changed
    /src/openlmis-invalid/openlmis-invalid.controller.js Changed
    /src/openlmis-invalid/openlmis-invalid.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-local-storage/local-storage.factory.js Changed
    Open in IDE #permalink
    /src/openlmis-local-storage/local-storage.service.js Changed
    Open in IDE #permalink
    /src/openlmis-locale/locale.controller.js Changed
    Open in IDE #permalink
    /src/openlmis-locale/locale.controller.spec.js Changed
    /src/openlmis-locale/openlmis-locale.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-modal/alert.service.js Changed
    Open in IDE #permalink
    /src/openlmis-modal/loading-modal-state.interceptor.js Changed
    /src/openlmis-modal/loading-modal.service.js Changed
    Open in IDE #permalink
    /src/openlmis-modal/notification.service.js Changed
    Open in IDE #permalink
    /src/openlmis-modal/openlmis-modal.service.js Changed
    Open in IDE #permalink
    /src/openlmis-modal-state/openlmis-modal-state.provider.js Changed
    /src/openlmis-offline/offline-service.js Changed
    /src/openlmis-offline/offline.constant.js Changed