OLMIS-4896: Modified user save endpoint to handle reference data user saving

Activity

FEOLMIS-3032 35

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1h 44m 23 resolve because we have solution in other review
    Reviewer - Complete 15m 1 I have no idea what does this test checks. Also I have a ...
    Reviewer - 0% reviewed      
    Reviewer - Complete 32m 6 what is the purpose of this class?
    Reviewer - Complete 56m 5 I am okay with creating a ticket for this. It may become ...
    Total   3h 27m 35  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Chongsun Ahn

    Did you update ref-distro .env file?

    Did you update ref-distro .env file?

    /src/.../web/ApiKeyControllerIntegrationTest.java Changed
    /src/.../web/BaseWebIntegrationTest.java Changed
    /src/.../web/UserControllerIntegrationTest.java Changed
    /src/main/.../dto/referencedata/BaseDto.java Changed 2
    /src/main/.../dto/referencedata/UserDto.java Changed 2
    /src/main/.../dto/LocalizedMessageDto.java Added 1
    Open in IDE #permalink
    /src/main/java/.../auth/dto/PageDto.java Added 5
    Open in IDE #permalink
    /src/main/.../auth/dto/UserSaveRequest.java Added 8
    /src/.../exception/ExternalApiException.java Added 1
    /src/main/.../exception/ServerException.java Added 1
    Open in IDE #permalink
    /src/main/java/.../auth/i18n/MessageKeys.java Changed
    /src/.../referencedata/UserReferenceDataService.java Changed 1
    /src/.../service/BaseCommunicationService.java Changed
    /src/main/.../service/PermissionService.java Changed
    /src/main/.../auth/service/UserService.java Changed 6
    /src/main/.../util/CustomSortDeserializer.java Added 1
    Open in IDE #permalink
    /src/.../util/DynamicPageTypeReference.java Changed 2
    /src/main/.../util/PageImplRepresentation.java Deleted
    Open in IDE #permalink
    /src/main/.../auth/web/UserController.java Changed
    /src/main/.../auth/web/WebErrorHandling.java Changed
    /src/main/.../schemas/roleAssignment.json Added
    Open in IDE #permalink
    /src/main/resources/schemas/user.json Added
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed
    /src/main/resources/messages_en.properties Changed
    /src/test/.../referencedata/BaseDtoTest.java Added
    /src/test/.../referencedata/UserDtoTest.java Changed
    /src/test/.../dto/LocalizedMessageDtoTest.java Added
    Open in IDE #permalink
    /src/test/java/.../auth/dto/PageDtoTest.java Added
    Open in IDE #permalink
    /src/test/.../dto/UserSaveRequestTest.java Added
    /src/test/.../auth/i18n/MessageKeysTest.java Changed
    /src/.../referencedata/UserReferenceDataServiceParameterizedTest.java Deleted 3
    Open in IDE #permalink
    /src/.../referencedata/UserReferenceDataServiceTest.java Added
    /src/.../service/BaseCommunicationServiceTest.java Changed
    /src/.../service/PermissionServiceTest.java Changed
    /src/test/.../service/UserServiceTest.java Changed
    /src/.../util/CustomSortDeserializerTest.java Added
    Open in IDE #permalink
    /src/test/.../web/WebErrorHandlingTest.java Added
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /gradle.properties Changed
    /.env Changed
    /deployment/perftest_env/.env Changed
    /deployment/test_env/.env Changed
    /deployment/uat_env/.env Changed
    /.env Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against