OLMIS-4813: Changed syntax for using datepicker

Activity

FEOLMIS-3023 7

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 16m 2 The mixin doesn't seem to work in this case. So I mimiced...
    Reviewer - Complete 23m 1 Please remove unnecessary "=" after "required".
    Reviewer - 98% reviewed 16m    
    Reviewer - Complete 14m 4 Yea, that might be problematic, could we maybe create ano...
    Total   1h 9m 7  
    #permalink

    Objectives

    The main objective is to check the changes made to the openlmis-datepicker. The rest of the review is just updating docker-composes and datepicker usages.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Mateusz Kwiatkowski

    I think that we should have info about changing ui-components version in all ...

    I think that we should have info about changing ui-components version in all changelogs.

    /CHANGELOG.md Changed
    /docker-compose.yml Changed
    /src/cce-inventory-item-status/status-update-modal.html Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /docker-compose.yml Changed
    /src/order-view/order-view.html Changed
    /src/proof-of-delivery-view/proof-of-delivery-view.html Changed
    /CHANGELOG.md Changed
    /docker-compose.yml Changed
    /docker-compose.yml Changed
    /src/admin-facility-add/facility-add.html Changed
    /src/admin-facility-add/facility-add.html.spec.js Changed
    /src/admin-facility-programs/facility-programs.html Changed 1
    /src/admin-facility-view/associated-programs.html Changed
    /src/admin-facility-view/facility-information.html Changed
    /src/admin-processing-schedule-edit/processing-schedule-edit.html Changed
    /CHANGELOG.md Changed
    /docker-compose.yml Changed
    /CHANGELOG.md Changed
    /docker-compose.yml Changed
    /src/requisition-search/requisition-search.html Changed
    /src/requisition-view/requisition-stock-count-date-modal.html Changed
    /CHANGELOG.md Changed
    /docker-compose.yml Changed
    /src/stock-adjustment-creation/adjustment-creation.html Changed
    /src/stock-choose-date-modal/choose-date-modal.html Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /docker-compose.yml Changed
    /src/openlmis-form/openlmis-datepicker-compile.directive.js Added
    Open in IDE #permalink
    /src/openlmis-form/openlmis-datepicker-compile.directive.spec.js Added
    Open in IDE #permalink
    /src/openlmis-form/openlmis-datepicker.directive.js Changed
    /src/openlmis-form/openlmis-datepicker.directive.spec.js Changed
    /src/openlmis-form/openlmis-datepicker.scss Changed 3
    Open in IDE #permalink
    /src/openlmis-table-form/input-auto-resize.directive.js Changed
    /src/openlmis-table-form/input-auto-resize.directive.spec.js Changed
    /CHANGELOG.md Changed 2
    /project.properties Changed
    /CHANGELOG.md Changed
    /docker-compose.yml Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against