OLMIS-4625: Create a parametrized job that runs contract tests

Activity

FEOLMIS-2952 8

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 28m 4 Hi Josh Zamor: is that acceptable?
    Reviewer - Complete 3m    
    Reviewer - Complete 15m    
    Reviewer - 7% reviewed 1m    
    Reviewer - Complete 9m 1 Do we need to update changelogs after those changes?
    Reviewer - Complete 11m 3 Thanks Jakub Kondrat, this is good to know!
    Total   1h 7m 8  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Jakub Kondrat

    Here's a parametrized job that runs contract tests: http://build.openlmis.org...

    Here's a parametrized job that runs contract tests: http://build.openlmis.org/job/OpenLMIS-contract-tests-pipeline/
    I added a parameter with branch name so that we can test against old releases (see v3.3.0 branch in contract-tests repository). Additionally, we push a STAGING image right after build. so we can use it in this external job. The version then gets appended to the .env file.

    Mateusz Kwiatkowski

    Do we need to update changelogs after those changes?

    Do we need to update changelogs after those changes?

    Jakub Kondrat

    I don't think we should state every update there, we already have entries abo...

    I don't think we should state every update there, we already have entries about Jenkinsfile being added

    Josh Zamor

    This LGTM. I left one comment about tag naming which I don't think needs to b...

    This LGTM. I left one comment about tag naming which I don't think needs to be a blocker atm.

    /Jenkinsfile Changed 4
    /Jenkinsfile Changed
    /Jenkinsfile Changed
    /docker-compose.stockmanagement.yml Added
    Open in IDE #permalink
    /docker-compose.stockmanagment.yml Deleted
    Open in IDE #permalink
    /Jenkinsfile Changed
    /Jenkinsfile Changed
    /Jenkinsfile Changed
    /Jenkinsfile Changed
    /Jenkinsfile Changed
    /Jenkinsfile Changed
    /Jenkinsfile Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against