OLMIS-4015: added Create Requisition Template page

Activity

FEOLMIS-2887 45

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1h 53m 15 FEOLMIS-2909
    Reviewer - 96% reviewed 1h 21m 27 Since the RepositoryImpl does nothing, could we just pass...
    Reviewer - 96% reviewed 1h 7m    
    Reviewer - 96% reviewed 12m 3 I'm still waiting
    Total   4h 34m 45  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Nikodem Graczewski

    Add changelog.

    Add changelog.

    Nikodem Graczewski

    According to #ui on Slack facility types, which are already added shouldn't s...

    According to #ui on Slack facility types, which are already added shouldn't show in the select.

    Nikodem Graczewski

    Shouldn't TemplateRepositoryImpl, TemplateRepository and TemplateResource res...

    Shouldn't TemplateRepositoryImpl, TemplateRepository and TemplateResource reside in teh requisition-template module?

    Mateusz Kwiatkowski

    It is too much work to make it work with all template screens, but I can just...

    It is too much work to make it work with all template screens, but I can just move those files to this module. Only problem is that in that module is RequisitionTemplate class which is not the one we are using here, the one we are using is from admin-template-configure-columns module.

    EDIT
    I will just create new admin-template module and move everything there, I will just resolve comments and close this review after I created new review for this new module.

    /docker-compose.yml Changed
    /src/admin-template-add/admin-template-add.module.js Added
    Open in IDE #permalink
    /src/admin-template-add/admin-template-add.routes.js Added 2
    /src/admin-template-add/avaiable-requisition-column.resource.js Deleted 1
    Open in IDE #permalink
    /src/admin-template-add/available-requisition-column.resource.js Added
    Open in IDE #permalink
    /src/admin-template-add/available-requisition-column.resource.spec.js Added
    Open in IDE #permalink
    /src/admin-template-add/messages_en.json Added 1
    /src/admin-template-add/template-add-modal.html Added 2
    /src/admin-template-add/template-add.controller.js Added 10
    /src/admin-template-add/template-add.controller.spec.js Added 3
    /src/admin-template-add/template-add.scss Deleted 7
    Open in IDE #permalink
    /src/admin-template-add/template-add.service.js Added 1
    Open in IDE #permalink
    /src/admin-template-add/template-add.service.spec.js Added
    Open in IDE #permalink
    /src/admin-template-add/template-repository-impl.js Added
    /src/admin-template-add/template-repository-impl.spec.js Added
    Open in IDE #permalink
    /src/admin-template-add/template-repository.js Added 2
    Open in IDE #permalink
    /src/admin-template-add/template-repository.spec.js Added
    Open in IDE #permalink
    /src/admin-template-add/template-resource.js Added
    Open in IDE #permalink
    /src/admin-template-add/template-resource.spec.js Added
    Open in IDE #permalink
    /src/admin-template-add/template.js Deleted
    Open in IDE #permalink
    /src/admin-template-configure-columns/requisition-template.service.js Changed 3
    /src/admin-template-configure-columns/requisition-template.service.spec.js Changed
    /src/admin-template-configure-columns/template-data-builder.spec.js Changed
    /src/admin-template-configure-columns/template.js Changed 1
    /src/admin-template-configure-columns/template.spec.js Changed 2
    /src/admin-template-list/admin-template-list.controller.js Changed
    Open in IDE #permalink
    /src/admin-template-list/admin-template-list.controller.spec.js Changed
    /src/admin-template-list/admin-template-list.html Changed 3
    /src/admin-template-list/admin-template-list.routes.js Changed
    /src/admin-template-list/messages_en.json Changed 1
    Open in IDE #permalink
    /src/requisition-template/requisition-template.js Changed
    /CHANGELOG.md Changed
    /project.properties Changed
    /src/openlmis-form/form-inline.scss Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against