OLMIS-4600: Added openlmisTagsInput directive

Activity

FEOLMIS-2877 12

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 14m 3 Error messages are duplicated.
    Reviewer - Complete 12m    
    Reviewer - Complete 34m 9 OK fair enough
    Total   1h 12  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Nikodem Graczewski

    Error messages are duplicated.

    Error messages are duplicated.

    /docker-compose.yml Changed
    /docker-compose.yml Changed
    /docker-compose.yml Changed
    /docker-compose.yml Changed
    /docker-compose.yml Changed
    /docker-compose.yml Changed
    /docker-compose.yml Changed
    /docker-compose.yml Changed
    /src/openlmis-debounce/ng-model-debounce.directive.js Changed
    Open in IDE #permalink
    /src/openlmis-debounce/ng-model-debounce.directive.spec.js Changed
    /src/openlmis-tags-input/messages_en.json Added 1
    Open in IDE #permalink
    /src/openlmis-tags-input/openlmis-tags-input.controller.js Added 3
    /src/openlmis-tags-input/openlmis-tags-input.controller.spec.js Added
    /src/openlmis-tags-input/openlmis-tags-input.directive.js Added 4
    /src/openlmis-tags-input/openlmis-tags-input.directive.spec.js Added
    /src/openlmis-tags-input/openlmis-tags-input.html Added 1
    /src/openlmis-tags-input/openlmis-tags-input.module.js Added
    Open in IDE #permalink
    /src/openlmis-tags-input/openlmis-tags-input.scss Added
    Open in IDE #permalink
    /CHANGELOG.md Changed 1
    /bower.json Changed
    /project.properties Changed 1
    /docker-compose.yml Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against