OLMIS-4599: Add GET /api/stockCardLineItemReasons/:id endpoint

Activity

FEOLMIS-2871 6

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 7m 2 nope, I don't see a reason to do this.
    Reviewer - Complete 7m 1 Łukasz Lewczyński Did you split it already?
    Reviewer - Complete 14m 3 If you want maybe you could add a simple test here too? h...
    Total   27m 6  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Mateusz Kwiatkowski

    Łukasz Lewczyński can you update title of the review?

    Łukasz Lewczyński can you update title of the review?

    Mateusz Kwiatkowski

    this easily could be 3 reviews, 1 for updating version, 1 for perf test and 1...

    this easily could be 3 reviews, 1 for updating version, 1 for perf test and 1 for actual functionality, maybe some testing could be done in separate review too

    Paweł Albecki

    Łukasz Lewczyński Did you split it already?

    Łukasz Lewczyński Did you split it already?

    Łukasz Lewczyński

    nope, I don't see a reason to do this.

    nope, I don't see a reason to do this.

    /.env Changed
    /deployment/perftest_env/.env Changed
    /deployment/test_env/.env Changed
    /deployment/uat_env/.env Changed
    /performance/tests/stockCardLineItemReason.yml Added
    Open in IDE #permalink
    /src/.../web/BaseWebIntegrationTest.java Changed
    /src/.../web/StockCardLineItemReasonControllerIntegrationTest.java Changed
    /src/main/.../reason/ReasonCategory.java Changed
    /src/.../reason/StockCardLineItemReason.java Changed
    /src/.../dto/StockCardLineItemReasonDto.java Changed
    /src/main/.../i18n/MessageKeys.java Changed 1
    /src/.../service/StockCardLineItemReasonService.java Changed
    /src/main/.../web/BaseController.java Added
    /src/.../web/StockCardLineItemReasonController.java Changed
    /src/main/.../web/StockEventsController.java Changed
    /src/main/resources/schemas/reason.json Changed
    /src/main/resources/api-definition.yaml Changed
    /src/main/resources/messages_en.properties Changed
    /src/test/.../reason/ReasonCategoryTest.java Added
    Open in IDE #permalink
    /src/.../reason/StockCardLineItemReasonTest.java Added
    Open in IDE #permalink
    /src/.../dto/StockCardLineItemReasonDtoTest.java Added
    Open in IDE #permalink
    /src/.../service/StockCardLineItemReasonServiceTest.java Changed
    /CHANGELOG.md Changed
    /gradle.properties Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against