OLMIS-4552: Updated Supervisory Node Service to use new API correctly

Activity

FEOLMIS-2815 3

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 4m 2 I found 3 places: *openlmis-stockmanagement -> work cor...
    Reviewer - Complete 6m    
    Reviewer - Complete 2m 1 Did you check other places affected by recent changes in ...
    Reviewer - 0% reviewed      
    Total   12m 3  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Łukasz Lewczyński

    no changelog because it does not exist in the cce service https://review.open...

    no changelog because it does not exist in the cce service

    Paweł Albecki

    Did you check other places affected by recent changes in supervisoryNodes API?

    Did you check other places affected by recent changes in supervisoryNodes API?

    Łukasz Lewczyński

    I found 3 places: *openlmis-stockmanagement -> work correctly *openlmis-req...

    I found 3 places:

    • openlmis-stockmanagement -> work correctly
    • openlmis-requisition -> work correctly
    • openlmis-cce -> fixed in this review
    /src/.../referencedata/SupervisoryNodeReferenceDataService.java Changed
    /src/.../service/ResourceCommunicationService.java Changed
    /src/.../referencedata/SupervisoryNodeReferenceDataServiceTest.java Changed
    /docker-compose.builder.yml Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against