OLMIS-3513: add tests for requisitionsForConvert endpoint

Activity

FEOLMIS-2757 11

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 14m 4 if demo data is changed, these tests will need to be adju...
    Reviewer - Complete 7m 7 this is last step in all our contract test, I don't see i...
    Reviewer - 38% reviewed 1m    
    Total   22m 11  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Łukasz Lewczyński

    Generally looks good but where is the case with space in filterValue parameter?

    Generally looks good but where is the case with space in filterValue parameter?

    Paweł Albecki

    It would require more work (create new requisition, login as different user)....

    It would require more work (create new requisition, login as different user). You can add it if you have time

    Łukasz Lewczyński

    We have one requisition ready to convert for administrator user, all steps ar...

    We have one requisition ready to convert for administrator user, all steps are defined, we only need to add few lines in feature file or I forgot about something?

    Paweł Albecki

    oh, last time I checked there was no requisition in demo data, it changes sit...

    oh, last time I checked there was no requisition in demo data, it changes situation!

    Łukasz Lewczyński

    program: Family Planning facility: HF01 - Kankao Health Facility req id: 21d1...

    program: Family Planning
    facility: HF01 - Kankao Health Facility
    req id: 21d138bc-f2c2-4188-adf3-a3aae381abde

    /src/cucumber/.../common/LoginStepDefs.java Changed
    /src/.../requisition/ProcessingPeriodUtils.java Changed
    Open in IDE #permalink
    /src/.../requisition/RequisitionStepDefs.java Changed
    /src/.../stockmanagement/PhysicalInventoriesStepDefs.java Changed
    /src/.../requisition_tests/RequisitionTests.feature Changed 6

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against