OLMIS-3174: Remove obsolete reasonNotWorkingOrNotInUse values

Activity

FEOLMIS-2738 5

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 16m 4 Thank you very much, Chongsun Ahn. I added Mateusz Kwiatk...
    Reviewer - Complete 7m 1 Looks good to me.
    Reviewer - 0% reviewed      
    Total   23m 5  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Chongsun Ahn

    Looks good to me.

    Looks good to me.

    Ben Leibert

    Thank you very much, Chongsun Ahn. I added Mateusz Kwiatkowski to the review ...

    Thank you very much, Chongsun Ahn. I added Mateusz Kwiatkowski to the review just incase we was able to get to it first. I don't think it needs two review, though, and will thus try marking this one as done.

    /demo-data/README.md Changed
    /demo-data/cce.cce_inventory_items.json Changed
    /src/.../repository/InventoryItemRepositoryIntegrationTest.java Changed
    /src/.../web/InventoryItemControllerIntegrationTest.java Changed
    /src/main/.../cce/domain/FunctionalStatus.java Changed 1
    /src/.../domain/ReasonNotWorkingOrNotInUse.java Changed 1
    /src/.../notifier/NonfunctionalCceNotifier.java Changed
    /src/.../service/InventoryStatusProcessor.java Changed
    /src/.../validator/InventoryItemValidator.java Changed
    /src/.../schemas/inventoryItems.schema.json Changed
    /src/main/.../schemas/inventoryItem.json Changed
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed
    /src/main/resources/messages_en.properties Changed
    /src/test/.../domain/InventoryItemTest.java Changed
    /src/.../notifier/NonfunctionalCceNotifierTest.java Changed
    /src/.../service/InventoryStatusProcessorTest.java Changed
    /src/.../validator/InventoryItemValidatorTest.java Changed
    /src/.../cce/InventoryItemDataBuilder.java Changed
    /src/cce-inventory-item/inventory-item-data-builder.spec.js Changed
    /src/cce-inventory-item-details/inventory-item-details.controller.spec.js Changed
    /src/cce-inventory-item-status/functional-status.constant.js Changed
    /src/cce-inventory-item-status/messages_en.json Changed 1
    Open in IDE #permalink
    /src/cce-inventory-item-status/reason-for-not-working.constant.js Changed
    Open in IDE #permalink
    /src/cce-inventory-item-status/status-update-modal.controller.js Changed
    /src/cce-inventory-item-status/status-update-modal.controller.spec.js Changed
    /src/cce-inventory-item-status/status-update-modal.html Changed
    /src/cce-inventory-item-status/status.scss Changed
    /src/facility-cce-status/facility-cce-status.scss Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against