OLMIS-4236 Fix faulty migration

Activity

FEOLMIS-2716 37

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 39m 21 yes and I changed it
    Reviewer - 2% reviewed 1m    
    Reviewer - Complete 3m    
    Reviewer - 59% reviewed 40m 11 I like this approach much better; just made a few minor s...
    Reviewer - Complete 27m 5 We should have some documentation how to write such tests...
    Total   1h 51m 37  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Łukasz Lewczyński

    I put v9.0.1 demo data to migration tests to make sure that there are some da...

    I put v9.0.1 demo data to migration tests to make sure that there are some data on the migration process. Those data are inserted after all migrations that were applied for OpenLMIS 3.2.1 because there were no problems with those migrations.

    Paweł Albecki

    We should have some documentation how to write such tests, e.g. here http://d...

    We should have some documentation how to write such tests, e.g. here http://docs.openlmis.org/en/latest/conventions/testing.html

    Łukasz Lewczyński

    I will create a doc on wiki page when I close this review, present it on the ...

    I will create a doc on wiki page when I close this review, present it on the tech call and when we all be on the same page, I will add page to docs.

    Chongsun Ahn

    I like this approach much better; just made a few minor suggestions.

    I like this approach much better; just made a few minor suggestions.

    /src/.../migration/BaseMigrationIntegrationTest.java Added 6
    /src/.../migration/CreateDispensablesMigrationIntegrationTest.java Added 2
    /src/.../migration/DispensablesMigrationIntegrationTest.java Deleted 3
    Open in IDE #permalink
    /src/.../migration/FlywayTarget.java Deleted
    Open in IDE #permalink
    /src/.../migration/FlywayTargetExecutionListener.java Deleted
    Open in IDE #permalink
    /src/.../migration/LatestMigrationIntegrationTest.java Deleted
    Open in IDE #permalink
    /src/.../migration/OrderablesMigrationIntegrationTest.java Deleted
    Open in IDE #permalink
    /src/.../migration/ReverseRelationshipOfOrderablesMigrationIntegrationTest.java Added 4
    /src/.../data/20170516132139856.1__insert_orderables.sql Deleted 2
    Open in IDE #permalink
    /src/.../data/20170516132139857__insert_orderables.sql Deleted 3
    Open in IDE #permalink
    /src/.../data/20171026190443925__demo_data_from_9.0.1.sql Deleted 9
    Open in IDE #permalink
    /src/.../data/20180119105956470__prepare_supply_lines.sql Deleted 4
    Open in IDE #permalink
    /src/.../migration/20180205211153916__add_type_to_dispensables.sql Changed
    Open in IDE #permalink
    /build.gradle Changed
    /build.sh Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against