OLMIS-4227: Added stock cards for more orderables at Depósito Distrital Cuamba

Activity

FEOLMIS-2688 9

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 26m 1 Paweł Albecki Chongsun Ahn Thanks and sorry, I just rever...
    Reviewer - Complete 2m    
    Reviewer - Complete 17m 2 related with change in contract test? mystery
    Reviewer - Complete 1m 1 maybe some different quantities?
    Total   47m 9  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Chongsun Ahn

    I am looking at the test server, and these changes don't seem correct. We sho...

    I am looking at the test server, and these changes don't seem correct. We should not have stock cards for commodity type orderables, but only trade item orderables at Cuamba district store in EPI. The fulfill orders screen is incorrect because we haven't finished OLMIS-4195.

    Paweł Albecki

    "We should not have stock cards for commodity type orderables" I thought our ...

    "We should not have stock cards for commodity type orderables"
    I thought our product model allow that.
    From OLMIS-3907:
    Limit the allowed Orderables that Stock Management may use (physical inventory, issue, adjustment, etc) to those in FTAP.

    Chongsun Ahn

    The statement you are referencing in OLMIS-3907 is about making sure that onl...

    The statement you are referencing in OLMIS-3907 is about making sure that only approved products are used by Stock Management. Meaning that if you are doing stock management for the Family Planning program, you would not see vaccine orderables in your list of products, since those are not approved for your program, but are for another program (EPI).

    We do allow stock cards for orderables are that exactly the same, in the common case model, where we do not use concepts like commodity types and trade items. But if we are trying to showcase the Ideal Product Model in our demo data, we do stock management at the trade item level. Think about it--if you are managing stock for Intervax BCG Lot A and B, and Merck BCG Lot A, why would you be tracking stock for something just generically called BCG?

    Paweł Albecki

    I get it now, thanks for clarification.

    I get it now, thanks for clarification.

    Klaudia Pałkowska

    Paweł Albecki Chongsun Ahn Thanks and sorry, I just reverted those changes.

    Paweł Albecki Chongsun Ahn Thanks and sorry, I just reverted those changes.

    /src/.../fulfillment/FulfillmentStepDefs.java Changed 2
    /demo-data/README.md Changed
    /demo-data/stockmanagement.stock_card_line_items.json Changed
    /demo-data/stockmanagement.stock_cards.json Changed
    /demo-data/stockmanagement.stock_event_line_items.json Changed 2
    /demo-data/stockmanagement.stock_events.json Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against