FEOLMIS-2688 OLMIS-4227: Added stock cards for more orderables at Depósito Distrital Cuamba

closed on 12 Mar 18

Author

Reviewers

OLMIS-4227: Added stock cards for more orderables at Depósito Distrital Cuamba

Activity

Details
Objectives
General Comments 5
Unresolved
Resolved
Number of files included: 6

openlmis-contract-tests 0
- Folder src/cucumber/java/org/openlmis/contract_tests/fulfillment 0
  - File FulfillmentStepDefs.java 2 Remove
openlmis-stockmanagement 0
- Folder demo-data 0
  - File README.md 0 Remove
  - File stockmanagement.stock_card_line_items.json 0 Remove
  - File stockmanagement.stock_cards.json 0 Remove
  - File stockmanagement.stock_event_line_items.json 2 Remove
  - File stockmanagement.stock_events.json 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Klaudia Pałkowska	Author	26m	1	Paweł Albecki Chongsun Ahn Thanks and sorry, I just rever...
Nikodem Graczewski	Reviewer - Complete	2m
Łukasz Lewczyński	Reviewer - Complete	17m	2	related with change in contract test? mystery
Mateusz Kwiatkowski	Reviewer - Complete	1m	1	maybe some different quantities?
Total		47m	9

Linked Issue:
OLMIS-4227

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Chongsun Ahn

I am looking at the test server, and these changes don't seem correct. We sho...

I am looking at the test server, and these changes don't seem correct. We should not have stock cards for commodity type orderables, but only trade item orderables at Cuamba district store in EPI. The fulfill orders screen is incorrect because we haven't finished OLMIS-4195.

09 Mar 18

Mateusz Kwiatkowski

Resolved

12 Mar 18

Paweł Albecki

"We should not have stock cards for commodity type orderables" I thought our ...

"We should not have stock cards for commodity type orderables"
I thought our product model allow that.
From OLMIS-3907:
Limit the allowed Orderables that Stock Management may use (physical inventory, issue, adjustment, etc) to those in FTAP.

09 Mar 18

Chongsun Ahn

The statement you are referencing in OLMIS-3907 is about making sure that onl...

The statement you are referencing in OLMIS-3907 is about making sure that only approved products are used by Stock Management. Meaning that if you are doing stock management for the Family Planning program, you would not see vaccine orderables in your list of products, since those are not approved for your program, but are for another program (EPI).

We do allow stock cards for orderables are that exactly the same, in the common case model, where we do not use concepts like commodity types and trade items. But if we are trying to showcase the Ideal Product Model in our demo data, we do stock management at the trade item level. Think about it--if you are managing stock for Intervax BCG Lot A and B, and Merck BCG Lot A, why would you be tracking stock for something just generically called BCG?

10 Mar 18

Paweł Albecki

I get it now, thanks for clarification.

10 Mar 18

Klaudia Pałkowska

Paweł Albecki Chongsun Ahn Thanks and sorry, I just reverted those changes.

12 Mar 18

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-2688

OLMIS-4227: Added stock cards for more orderables at Depósito Distrital Cuamba

FEOLMIS-2688 9

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Chongsun Ahn

Paweł Albecki

Chongsun Ahn

Paweł Albecki

Klaudia Pałkowska

Log time against

OLMIS-4227: Added stock cards for more orderables at Depósito Distrital Cuamba

FEOLMIS-2688 9

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Chongsun Ahn

Paweł Albecki

Chongsun Ahn

Paweł Albecki

Klaudia Pałkowska

Log time against