FEOLMIS-2688
OLMIS-4227: Added stock cards for more orderables at Depósito Distrital Cuamba
Details
Participant | Role | Time Spent | Comments | Latest Comment |
---|---|---|---|---|
Author | 26m | 1 | Paweł Albecki Chongsun Ahn Thanks and sorry, I just rever... | |
Reviewer - Complete | 2m | |||
Reviewer - Complete | 17m | 2 | related with change in contract test? mystery | |
Reviewer - Complete | 1m | 1 | maybe some different quantities? | |
Total | 47m | 9 |
- Linked Issue:
-
Branches in review
General Comments
Paweł Albecki
"We should not have stock cards for commodity type orderables" I thought our ..."We should not have stock cards for commodity type orderables"
I thought our product model allow that.
From OLMIS-3907:
Limit the allowed Orderables that Stock Management may use (physical inventory, issue, adjustment, etc) to those in FTAP.
Chongsun Ahn
The statement you are referencing in OLMIS-3907 is about making sure that onl...The statement you are referencing in OLMIS-3907 is about making sure that only approved products are used by Stock Management. Meaning that if you are doing stock management for the Family Planning program, you would not see vaccine orderables in your list of products, since those are not approved for your program, but are for another program (EPI).
We do allow stock cards for orderables are that exactly the same, in the common case model, where we do not use concepts like commodity types and trade items. But if we are trying to showcase the Ideal Product Model in our demo data, we do stock management at the trade item level. Think about it--if you are managing stock for Intervax BCG Lot A and B, and Merck BCG Lot A, why would you be tracking stock for something just generically called BCG?
Klaudia Pałkowska
Paweł Albecki Chongsun Ahn Thanks and sorry, I just reverted those changes.Paweł Albecki Chongsun Ahn Thanks and sorry, I just reverted those changes.
I am looking at the test server, and these changes don't seem correct. We should not have stock cards for commodity type orderables, but only trade item orderables at Cuamba district store in EPI. The fulfill orders screen is incorrect because we haven't finished OLMIS-4195.
Mateusz Kwiatkowski marked as Resolved 12 Mar 18