OLMIS-4129 Add button to dismiss alerts

Activity

FEOLMIS-2665 17

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 21m 6 Ticket created: https://openlmis.atlassian.net/browse/OLM...
    Reviewer - Complete 11m 4 Thanks.
    Reviewer - Complete 25m 7 I tried it and as you said increasing timeout didn't help...
    Total   57m 17  
    #permalink

    Objectives

    • Review new method in CCE alert factory.
    • Review new dismiss alert button with dismiss alert functionality.


    I need a bit of help to show the alertService message if the save alert fails, but I'm not sure why it's not working.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Chongsun Ahn

    There are a number of changes in this review unrelated to the ticket; just fo...

    There are a number of changes in this review unrelated to the ticket; just focus on the changes related to the unresolved issues.

    /src/cce-alert/cce-alert-data-builder.js Changed 3
    /src/cce-alert/cce-alert.factory.js Changed 3
    /src/cce-alert/cce-alert.factory.spec.js Changed 1
    /src/cce-inventory-item-status/messages_en.json Changed
    /src/cce-inventory-item-status/status-update-modal.controller.js Changed 8
    /src/cce-inventory-item-status/status-update-modal.controller.spec.js Changed
    /src/cce-inventory-item-status/status-update-modal.html Changed
    /src/cce-inventory-item-status/status.scss Changed 1

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against