OLMIS-4016: Use facility type to find correct req template

Activity

FEOLMIS-2536 12

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 22m 6 I think in those tests we don't case about correct respon...
    Reviewer - Complete 12m    
    Reviewer - Complete 25m 6 probably we should use builders here
    Total   59m 12  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/.../requisition/RequisitionStepDefs.java Changed
    /src/.../requisition_tests/RequisitionTests.feature Changed 1
    /demo-data/requisition.columns_maps.json Changed 2
    /demo-data/requisition.requisition_templates.json Changed
    /src/.../repository/RequisitionTemplateRepositoryIntegrationTest.java Changed
    /src/.../web/BatchRequisitionControllerIntegrationTest.java Changed
    /src/.../web/RequisitionControllerIntegrationTest.java Changed
    /src/main/.../dto/BasicProgramDto.java Changed
    /src/main/.../dto/MinimalFacilityDto.java Changed
    /src/main/.../requisition/dto/ProgramDto.java Changed
    /src/.../dto/TimelinessReportFacilityDto.java Changed
    /src/main/.../i18n/MessageKeys.java Changed
    /src/.../impl/RequisitionTemplateRepositoryImpl.java Deleted
    Open in IDE #permalink
    /src/.../custom/RequisitionTemplateRepositoryCustom.java Deleted
    Open in IDE #permalink
    /src/.../repository/RequisitionTemplateRepository.java Changed
    /src/main/.../service/RequisitionService.java Changed
    /src/main/.../web/RequisitionController.java Changed 1
    /src/main/resources/messages_en.properties Changed 2
    /src/.../domain/RequisitionBuilderTest.java Changed
    /src/.../domain/RequisitionLineItemTest.java Changed
    /src/test/.../dto/BasicProgramDtoTest.java Added
    Open in IDE #permalink
    /src/test/.../dto/FacilityDtoTest.java Added
    Open in IDE #permalink
    /src/test/.../dto/MinimalFacilityDtoTest.java Added
    Open in IDE #permalink
    /src/test/.../dto/ProgramDtoTest.java Added
    Open in IDE #permalink
    /src/.../dto/TimelinessReportFacilityDtoTest.java Added
    Open in IDE #permalink
    /src/.../service/ApprovalNotifierTest.java Changed 2
    /src/.../service/ApprovedRequisitionNotifierTest.java Changed
    /src/.../service/ConvertToOrderNotifierTest.java Changed 2
    /src/.../service/JasperReportsViewServiceTest.java Changed
    /src/.../service/RequisitionServiceTest.java Changed
    /src/.../service/RequisitionStatusNotifierTest.java Changed 2
    /src/.../testutils/ApprovedProductDtoDataBuilder.java Changed
    /src/test/.../testutils/DtoGenerator.java Changed
    /src/.../testutils/OrderableDtoDataBuilder.java Changed
    /src/.../utils/DatePhysicalStockCountCompletedEnabledPredicateTest.java Changed
    /src/.../web/BasicRequisitionDtoBuilderTest.java Changed
    /src/.../web/RequisitionControllerTest.java Changed
    /src/.../web/RequisitionDtoBuilderTest.java Changed
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against