OLMIS-3996: Updated dto to contain object references and service to throw...

Activity

FEOLMIS-2500 14

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 19m 2 Changelog was added previously.
    Reviewer - Complete 6m 9 toSet instead of toList to avoid duplication on the resul...
    Reviewer - Complete 8m 3 add changelog
    Total   33m 14  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Łukasz Lewczyński

    2500 review !!!

    2500 review !!!

    Mateusz Kwiatkowski

    add changelog

    add changelog

    Klaudia Pałkowska

    Changelog was added previously.

    Changelog was added previously.

    /src/.../stockmanagement/StockReasonsStepDefs.java Changed
    Open in IDE #permalink
    /src/.../web/ValidReasonAssignmentControllerTest.java Changed
    /src/main/.../domain/reason/ReasonType.java Changed 1
    /src/main/.../dto/ObjectReferenceDto.java Changed 6
    /src/.../dto/ValidReasonAssignmentDto.java Changed
    /src/main/.../i18n/MessageKeys.java Changed
    /src/main/.../service/ResourceNames.java Added
    Open in IDE #permalink
    /src/.../service/ValidReasonAssignmentService.java Changed 2
    /src/.../web/ValidReasonAssignmentController.java Changed
    /src/main/.../schemas/referenceObjectDto.json Changed 1
    Open in IDE #permalink
    /src/.../schemas/validReasonAssignment.json Changed
    Open in IDE #permalink
    /src/main/resources/messages_en.properties Changed
    /src/test/.../reason/ReasonTypeTest.java Added
    Open in IDE #permalink
    /src/.../service/ValidReasonAssignmentServiceTest.java Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against