FEOLMIS-2491 OLMIS-4086: Support multiple requisition templates per program

closed on 09 Feb 18

Author

Reviewers

OLMIS-4086: Support multiple requisition templates per program

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 44

openlmis-contract-tests 0
- File .env 0 Remove
openlmis-deployment 0
- Folder deployment 0
  - Folder perftest_env 0
    - File .env 0 Remove
  - Folder test_env 0
    - File .env 0 Remove
  - Folder uat_env 0
    - File .env 0 Remove
openlmis-ref-distro 0
- File .env 0 Remove
openlmis-requisition 0
- Folder demo-data 0
  - File requisition.requisition_template_assignments.json 0 Remove
  - File requisition.requisition_templates.json 0 Remove
- Folder src 0
  - Folder integration-test/java/org/openlmis/requisition 0
    - Folder repository 0
      - File RequisitionTemplateRepositoryIntegrationTest.java 0 Remove
    - Folder web 0
      - File BaseWebIntegrationTest.java 0 Remove
      - File RequisitionTemplateControllerIntegrationTest.java 0 Remove
    - File ExposedMessageSourceIntegrationTest.java 0 Remove
  - Folder main 0
    - Folder java/org/openlmis/requisition 0
      - Folder domain 0
        
        File RequisitionLineItem.java 0 Remove
        
        File RequisitionTemplate.java 9 Remove
        
        File RequisitionTemplateAssignment.java 0 Remove
      - Folder dto 0
        
        File BasicRequisitionTemplateDto.java 0 Remove
        
        File ObjectReferenceDto.java 2 Remove
        
        File RequisitionTemplateDto.java 2 Remove
      - Folder i18n 0
        
        File MessageKeys.java 0 Remove
      - Folder repository 0
        
        Folder custom/impl 0
        
        File RequisitionTemplateRepositoryImpl.java 0 Remove
        
        File ReferenceDataRepository.java 0 Remove
        
        File RequisitionTemplateRepository.java 0 Remove
      - Folder service/referencedata 0
        
        File FacilityTypeReferenceDataService.java 0 Remove
      - Folder validate 0
        
        File RequisitionTemplateValidator.java 0 Remove
      - Folder web 0
        
        File RequisitionTemplateController.java 0 Remove
        
        File RequisitionTemplateDtoBuilder.java 2 Remove
        
        File ResourceNames.java 0 Remove
    - Folder resources 0
      - Folder db/migration 0
        
        File 20180202145705498__created_requisition_template_assignments_table.sql 2 Remove
      - Folder schemas 0
        
        File referenceObjectDto.json 0 Remove
        
        File requisitionTemplate.json 0 Remove
      - File api-definition.yaml 2 Remove
      - File messages_en.properties 0 Remove
      - File messages_es.properties 0 Remove
      - File messages_fr.properties 0 Remove
      - File messages_pt.properties 0 Remove
  - Folder test/java/org/openlmis/requisition 0
    - Folder domain 0
      - File RequisitionTemplateAssignmentTest.java 0 Remove
      - File RequisitionTemplateTest.java 0 Remove
    - Folder dto 0
      - File RequisitionTemplateDtoTest.java 0 Remove
    - Folder service/referencedata 0
      - File FacilityTypeReferenceDataServiceTest.java 0 Remove
    - Folder testutils 0
      - File RequisitionTemplateDataBuilder.java 0 Remove
    - Folder validate 0
      - File RequisitionTemplateValidatorTest.java 0 Remove
    - Folder web 0
      - File RequisitionDtoBuilderTest.java 0 Remove
- File CHANGELOG.md 0 Remove
- File build.gradle 0 Remove
- File gradle.properties 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Łukasz Lewczyński	Author	21m	9	Theoretically it is impossible to have null in this field...
Sebastian Brudziński	Reviewer - 4% reviewed	1m
Paweł Albecki	Reviewer - Complete	38m	7	it's lazy anyway
Mateusz Kwiatkowski	Reviewer - Complete	15m	3	we should probably test those 2 methods
Total		1h 15m	19

Linked Issue:
OLMIS-4086

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/src/.../repository/ReferenceDataRepository.java Deleted

Click to load diff

/src/main/resources/messages_es.properties Deleted

Click to load diff

/src/main/resources/messages_fr.properties Deleted

Click to load diff

/src/main/resources/messages_pt.properties Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-2491

OLMIS-4086: Support multiple requisition templates per program

FEOLMIS-2491 19

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

OLMIS-4086: Support multiple requisition templates per program

FEOLMIS-2491 19

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against