OLMIS-4086: Support multiple requisition templates per program

Activity

FEOLMIS-2491 19

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 21m 9 Theoretically it is impossible to have null in this field...
    Reviewer - 4% reviewed 1m    
    Reviewer - Complete 38m 7 it's lazy anyway
    Reviewer - Complete 15m 3 we should probably test those 2 methods
    Total   1h 15m 19  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /.env Changed
    /deployment/perftest_env/.env Changed
    /deployment/test_env/.env Changed
    /deployment/uat_env/.env Changed
    /.env Changed
    /demo-data/requisition.requisition_template_assignments.json Added
    Open in IDE #permalink
    /demo-data/requisition.requisition_templates.json Changed
    /src/.../repository/RequisitionTemplateRepositoryIntegrationTest.java Changed
    /src/.../web/BaseWebIntegrationTest.java Changed
    /src/.../web/RequisitionTemplateControllerIntegrationTest.java Changed
    /src/.../requisition/ExposedMessageSourceIntegrationTest.java Added
    Open in IDE #permalink
    /src/main/.../domain/RequisitionLineItem.java Changed
    /src/main/.../domain/RequisitionTemplate.java Changed 9
    /src/.../domain/RequisitionTemplateAssignment.java Added
    Open in IDE #permalink
    /src/.../dto/BasicRequisitionTemplateDto.java Changed
    /src/main/.../dto/ObjectReferenceDto.java Changed 2
    /src/main/.../dto/RequisitionTemplateDto.java Changed 2
    /src/main/.../i18n/MessageKeys.java Changed
    /src/.../impl/RequisitionTemplateRepositoryImpl.java Changed
    /src/.../repository/ReferenceDataRepository.java Deleted
    Open in IDE #permalink
    /src/.../repository/RequisitionTemplateRepository.java Changed
    /src/.../referencedata/FacilityTypeReferenceDataService.java Added
    Open in IDE #permalink
    /src/.../validate/RequisitionTemplateValidator.java Changed
    /src/.../web/RequisitionTemplateController.java Changed
    /src/.../web/RequisitionTemplateDtoBuilder.java Added 2
    /src/main/.../web/ResourceNames.java Added
    Open in IDE #permalink
    /src/.../migration/20180202145705498__created_requisition_template_assignments_table.sql Added 2
    Open in IDE #permalink
    /src/main/.../schemas/referenceObjectDto.json Added
    Open in IDE #permalink
    /src/main/.../schemas/requisitionTemplate.json Changed
    /src/main/resources/api-definition.yaml Changed 2
    /src/main/resources/messages_en.properties Changed
    /src/main/resources/messages_es.properties Deleted
    Open in IDE #permalink
    /src/main/resources/messages_fr.properties Deleted
    Open in IDE #permalink
    /src/main/resources/messages_pt.properties Deleted
    Open in IDE #permalink
    /src/.../domain/RequisitionTemplateAssignmentTest.java Added
    Open in IDE #permalink
    /src/.../domain/RequisitionTemplateTest.java Changed
    /src/.../dto/RequisitionTemplateDtoTest.java Changed
    /src/.../referencedata/FacilityTypeReferenceDataServiceTest.java Added
    Open in IDE #permalink
    /src/.../testutils/RequisitionTemplateDataBuilder.java Changed
    /src/.../validate/RequisitionTemplateValidatorTest.java Changed
    /src/.../web/RequisitionDtoBuilderTest.java Changed
    /CHANGELOG.md Changed
    /build.gradle Changed
    /gradle.properties Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against