OLMIS-2695: Merged period search endpoints

Activity

FEOLMIS-2410 16

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 22m 6 the class has been removed so I resolve the issue
    Reviewer - Complete 32m 1 Łukasz Lewczyński Could you take a look at failed Sonar Q...
    Reviewer - 33% reviewed 55m 4 good
    Reviewer - Complete 1h 7m 5 This is required, after removing it controller integratio...
    Total   2h 56m 16  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Łukasz Lewczyński

    I checked and only the requisition service uses the processing period search ...

    I checked and only the requisition service uses the processing period search endpoints

    Klaudia Pałkowska

    Łukasz Lewczyński Could you take a look at failed Sonar Quantity Gate (requis...

    Łukasz Lewczyński Could you take a look at failed Sonar Quantity Gate (requisition service)?

    Łukasz Lewczyński

    Mateusz Kwiatkowski could you take a look at that?

    Mateusz Kwiatkowski could you take a look at that?

    /src/.../requisition/ProcessingPeriodUtils.java Changed
    /src/.../requisition/RequisitionStepDefs.java Changed
    /src/.../repository/ProcessingPeriodRepositoryIntegrationTest.java Changed
    /src/.../web/BaseWebIntegrationTest.java Changed
    /src/.../web/IdealStockAmountControllerIntegrationTest.java Changed
    /src/.../web/ProcessingPeriodControllerIntegrationTest.java Changed
    /src/.../referencedata/PageImplRepresentation.java Changed
    /src/.../impl/ProcessingPeriodRepositoryImpl.java Deleted 5
    Open in IDE #permalink
    /src/.../custom/ProcessingPeriodRepositoryCustom.java Deleted
    Open in IDE #permalink
    /src/.../repository/ProcessingPeriodRepository.java Changed
    /src/.../repository/ProcessingScheduleRepository.java Changed
    /src/.../service/ProcessingPeriodSearchParams.java Added 2
    /src/.../service/ProcessingPeriodService.java Changed 2
    /src/.../messagekeys/ProcessingPeriodMessageKeys.java Changed
    /src/.../messagekeys/ProcessingScheduleMessageKeys.java Changed
    /src/main/.../util/CustomSortDeserializer.java Added
    Open in IDE #permalink
    /src/.../util/ProcessingPeriodComparator.java Deleted 1
    Open in IDE #permalink
    /src/.../util/ProcessingPeriodDtoComparator.java Deleted
    Open in IDE #permalink
    /src/.../validate/ProcessingPeriodValidator.java Changed
    /src/.../recordhandler/IdealStockAmountProcessor.java Changed
    /src/.../web/ProcessingPeriodController.java Changed
    /src/.../schemas/processingPeriodPage.json Added
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed
    /src/main/resources/messages_en.properties Changed 2
    /src/.../service/ProcessingPeriodSearchParamsTest.java Added
    /src/.../service/ProcessingPeriodServiceTest.java Changed
    /src/.../testbuilder/ProcessingPeriodDataBuilder.java Added
    /src/.../testbuilder/ProcessingScheduleDataBuilder.java Changed
    /src/.../messagekeys/ProcessingPeriodMessageKeysTest.java Changed
    /src/.../util/ProcessingPeriodComparatorTest.java Deleted
    Open in IDE #permalink
    /src/.../util/ProcessingPeriodDtoComparatorTest.java Deleted
    Open in IDE #permalink
    /src/.../validate/ProcessingPeriodValidatorTest.java Changed
    /src/.../recordhandler/IdealStockAmountProcessorTest.java Changed
    /CHANGELOG.md Changed
    /performance/tests/requisition.yml Changed
    /src/.../referencedata/PeriodReferenceDataService.java Changed
    /src/.../utils/CustomSortDeserializer.java Added
    Open in IDE #permalink
    /src/.../utils/PageImplRepresentation.java Changed
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against