OLMIS-2695: added case insensitive unique index for schedule code and name

Activity

FEOLMIS-2395 13

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1h 55m 2 Why? we have mulitple codes but we are using it only in P...
    Reviewer - Complete 20m 2 nvm
    Reviewer - 11% reviewed 12m 5 because it's designed value object that shoud be used
    Reviewer - 11% reviewed 11m 4 Added a couple of comments.
    Total   2h 38m 13  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Chongsun Ahn

    Added a couple of comments.

    Added a couple of comments.

    /src/.../repository/IdealStockAmountRepositoryIntegrationTest.java Changed
    /src/.../repository/ProcessingScheduleRepositoryIntegrationTest.java Changed
    /src/.../repository/RequisitionGroupProgramScheduleRepositoryIntegrationTest.java Changed
    /src/.../repository/RequisitionGroupRepositoryIntegrationTest.java Changed
    /src/.../web/IdealStockAmountControllerIntegrationTest.java Changed
    /src/.../web/ProcessingPeriodControllerIntegrationTest.java Changed
    /src/.../web/ProcessingScheduleControllerIntegrationTest.java Changed
    /src/.../web/RequisitionGroupControllerIntegrationTest.java Changed
    /src/.../web/UserControllerIntegrationTest.java Changed
    /src/main/.../domain/ProcessingSchedule.java Changed 8
    /src/main/.../dto/ProcessingScheduleDto.java Changed 2
    /src/.../errorhandling/RefDataErrorHandling.java Changed
    /src/.../impl/IdealStockAmountRepositoryImpl.java Changed
    /src/.../repository/ProcessingScheduleRepository.java Changed 2
    /src/.../processor/ParseProcessingPeriod.java Changed
    /src/.../recordhandler/IdealStockAmountProcessor.java Changed
    /src/.../migration/20180116111906513__changed_constraint_to_unique_index_for_schedule.sql Added
    Open in IDE #permalink
    /src/test/.../domain/ProcessingPeriodTest.java Changed
    /src/.../domain/ProcessingScheduleTest.java Added
    /src/.../domain/SupervisionRoleAssignmentTest.java Changed
    /src/test/.../domain/SupervisoryNodeTest.java Changed
    /src/test/.../domain/UserTest.java Changed
    /src/.../dto/ProcessingScheduleDtoTest.java Added
    /src/.../testbuilder/ProcessingScheduleDataBuilder.java Added
    /src/.../validate/IdealStockAmountValidatorTest.java Changed
    /src/.../processor/FormatProcessingPeriodTest.java Changed
    /src/.../processor/ParseProcessingPeriodTest.java Changed
    /src/.../recordhandler/IdealStockAmountProcessorTest.java Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against